aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2017-03-28 22:39:35 +0000
committerGravatar Philipp Wollermann <philwo@google.com>2017-03-29 14:22:26 +0200
commitdb4dec23008069a4c5ceccdb686e515808c921ba (patch)
treeacec73f2e74a6f593c5f0e7dd5df22450654a15f /src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java
parent0e866a8b732e31df1a4ddfd13c4870d4721de70b (diff)
Clear AspectValues when discarding analysis cache, along with ConfiguredTargetValues. Also clear transitive packages for both, even for top-level targets.
This is not expected to save significant memory, but is expected to reduce the number of references to Packages, allowing them to be dropped more easily when discarding analysis cache and running in batch mode. PiperOrigin-RevId: 151508877
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java
index abcf5962b0..0c418841a7 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java
@@ -183,10 +183,11 @@ public final class SkyframeBuildView {
*
* @see com.google.devtools.build.lib.analysis.BuildView.Options#discardAnalysisCache
*/
- public void clearAnalysisCache(Collection<ConfiguredTarget> topLevelTargets) {
+ public void clearAnalysisCache(
+ Collection<ConfiguredTarget> topLevelTargets, Collection<AspectValue> topLevelAspects) {
// TODO(bazel-team): Consider clearing packages too to save more memory.
skyframeAnalysisWasDiscarded = true;
- skyframeExecutor.clearAnalysisCache(topLevelTargets);
+ skyframeExecutor.clearAnalysisCache(topLevelTargets, topLevelAspects);
}
/**