diff options
author | Janak Ramakrishnan <janakr@google.com> | 2016-07-18 20:33:28 +0000 |
---|---|---|
committer | Dmitry Lomov <dslomov@google.com> | 2016-07-19 18:09:45 +0000 |
commit | 063b4887b5ac2b1baaf5f6753abaa07736073831 (patch) | |
tree | 7729e435bd7e28970a48ad4aa159fcca04d1975d /src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java | |
parent | ee36dd3f5db8e7ad129b2782a24eb97a0478fc42 (diff) |
Sort the results returned by the HybridGlobber if we are using results from Skyframe globbing. This adds a log(n) factor to uses of globs, but getting globs to be returned in a reasonable order that can be emulated by legacy globbing is hard and bug-prone right now, and we must sort anyway if we are merging legacy and Skyframe globs.
Note that this log(n) factor is already present on clean builds with legacy globbing. If we end up seeing performance issues on incremental loading, we can investigate making GlobFunction efficiently return elements in sorted order. (We would still need to sort if merging legacy and Skyframe globs, but that should be a relatively rare occurrence, and can be dealt with by a more efficient merge sort if necessary.)
--
MOS_MIGRATED_REVID=127752554
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkyframeActionExecutor.java')
0 files changed, 0 insertions, 0 deletions