diff options
| author |  ulfjack <ulfjack@google.com> | 2018-02-02 07:45:22 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-02-02 07:47:16 -0800 |
| commit | 8b5a64b87f13cf613f9e72d7710294304c091ff1 (patch) | |
| tree | 4fb5ed505a36d5e228f3ff61de9854a9dd141a0e /src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java | |
| parent | 757fe08b455d8b88fd89505a506c7303988cc639 (diff) | |
Fix error handling in skyframe target pattern parsing
Bazel completely swallowed errors in some cases, e.g., if the pattern is
invalid like bazel build foo//bar:baz.
Note that it previously silently ignored empty targets if --experimental_skyframe_target_pattern_evaluator was passed, and now fails (which is consistent with legacy behavior). This is an intentional change, but may break users who are using the experimental flag and are passing empty strings to Bazel.
PiperOrigin-RevId: 184282856
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java index b8b1e292b7..04ff12caf5 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyFunctions.java @@ -47,6 +47,8 @@ public final class SkyFunctions { public static final SkyFunctionName PACKAGE_ERROR = SkyFunctionName.create("PACKAGE_ERROR"); public static final SkyFunctionName TARGET_MARKER = SkyFunctionName.create("TARGET_MARKER"); public static final SkyFunctionName TARGET_PATTERN = SkyFunctionName.create("TARGET_PATTERN"); + public static final SkyFunctionName TARGET_PATTERN_ERROR = + SkyFunctionName.create("TARGET_PATTERN_ERROR"); public static final SkyFunctionName PREPARE_DEPS_OF_PATTERNS = SkyFunctionName.create("PREPARE_DEPS_OF_PATTERNS"); public static final SkyFunctionName PREPARE_DEPS_OF_PATTERN = |