diff options
| author |  tomlu <tomlu@google.com> | 2018-06-18 16:16:36 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-18 16:18:08 -0700 |
| commit | 9e91f20bb31e44b4be836996ac9d91af61e1e822 (patch) | |
| tree | 7e7c116290099ef5a8e16e67a9d4f5a0c908fbf9 /src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java | |
| parent | d4406d644efcf86327834a56b01cc212389e52e7 (diff) | |
Remove support for --discard_actions_after_execution.
The memory savings from this flag are not worth the complexity, and it interferes with action restarting.
RELNOTES: Remove support for --discard_actions_after_execution.
PiperOrigin-RevId: 201077905
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java index 97f06fed14..4e4cc54e58 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java @@ -574,8 +574,10 @@ public final class SequencedSkyframeExecutor extends SkyframeExecutor { */ @Override public void decideKeepIncrementalState( - boolean batch, boolean keepStateAfterBuild, boolean shouldTrackIncrementalState, - boolean discardAnalysisCache, boolean discardActionsAfterExecution, + boolean batch, + boolean keepStateAfterBuild, + boolean shouldTrackIncrementalState, + boolean discardAnalysisCache, EventHandler eventHandler) { Preconditions.checkState(!active); boolean oldValueOfTrackIncrementalState = trackIncrementalState; @@ -604,7 +606,6 @@ public final class SequencedSkyframeExecutor extends SkyframeExecutor { } } - removeActionsAfterEvaluation.set(!trackIncrementalState && discardActionsAfterExecution); // Now check if it is necessary to wipe the previous state. We do this if either the previous // or current incrementalStateRetentionStrategy requires the build to have been isolated. if (oldValueOfTrackIncrementalState != trackIncrementalState) { |