diff options
author | 2015-02-12 17:08:06 +0000 | |
---|---|---|
committer | 2015-02-12 17:08:06 +0000 | |
commit | f04efcc42a4ca0e9a4f2936953c44e19947e342d (patch) | |
tree | 3be29eadbb142fce2344a5f396de7c9795eefc6c /src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalValue.java | |
parent | 6bf0d27fef0a135e5f158c1b0b5ac0ba3ebc9303 (diff) |
Introduce a PackageBoundaryMode enum to FilesetTraversalParams.
This enables the introduction of a third behavior mode when
RecursiveFilesystemTraversalFunction encounters a package boundary: on top of
the existing cross/no-cross behavior, it can now bail out with an error.
This is preparatory work to support Skyframe-native Filesets.
The CL also contains a couple of prettifying cleanups (in ActionCacheChecker
and in FilesetManifestAction).
--
MOS_MIGRATED_REVID=86185105
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalValue.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalValue.java | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalValue.java index 023b1cf009..f72792fd08 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/RecursiveFilesystemTraversalValue.java @@ -17,6 +17,7 @@ import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Objects; import com.google.common.base.Optional; import com.google.common.base.Preconditions; +import com.google.devtools.build.lib.actions.FilesetTraversalParams.PackageBoundaryMode; import com.google.devtools.build.lib.collect.nestedset.NestedSet; import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder; import com.google.devtools.build.lib.collect.nestedset.Order; @@ -120,7 +121,7 @@ public final class RecursiveFilesystemTraversalValue implements SkyValue { final boolean isGenerated; /** Whether traversal should descend into directories that are roots of subpackages. */ - final boolean crossPkgBoundaries; + final PackageBoundaryMode crossPkgBoundaries; /** * Whether to skip checking if the root (if it's a directory) contains a BUILD file. @@ -135,7 +136,7 @@ public final class RecursiveFilesystemTraversalValue implements SkyValue { @Nullable final String errorInfo; public TraversalRequest(RootedPath path, boolean isRootGenerated, - boolean crossPkgBoundaries, boolean skipTestingForSubpackage, + PackageBoundaryMode crossPkgBoundaries, boolean skipTestingForSubpackage, @Nullable String errorInfo) { this.path = path; this.isGenerated = isRootGenerated; @@ -188,8 +189,8 @@ public final class RecursiveFilesystemTraversalValue implements SkyValue { public String toString() { return String.format( "TraversalParams(root=%s, is_generated=%d, skip_testing_for_subpkg=%d," - + " pkg_boundaries=%d)", path, isGenerated ? 1 : 0, skipTestingForSubpackage ? 1 : 0, - crossPkgBoundaries ? 1 : 0); + + " pkg_boundaries=%s)", path, isGenerated ? 1 : 0, skipTestingForSubpackage ? 1 : 0, + crossPkgBoundaries); } } |