Move target pattern parsing to key construction time

So that a subsequent commit can take advantage of semantic information
known only after target patterns have been parsed, this commit moves
parsing from pattern evaluation time to pattern key construction time.

This leads toward more efficient processing of target patterns in
target pattern sequence evaluation.

--
MOS_MIGRATED_REVID=94025646

1 files changed, 3 insertions, 4 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PrepareDepsOfPatternsValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/PrepareDepsOfPatternsValue.java
index 88f034cee2..918b31fd15 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/PrepareDepsOfPatternsValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/PrepareDepsOfPatternsValue.java
@@ -37,8 +37,7 @@ public final class PrepareDepsOfPatternsValue implements SkyValue {
   }
 
   @ThreadSafe
-  public static SkyKey key(ImmutableList<String> patterns, FilteringPolicy policy,
-      String offset) {
+  public static SkyKey key(ImmutableList<String> patterns, FilteringPolicy policy, String offset) {
     return new SkyKey(SkyFunctions.PREPARE_DEPS_OF_PATTERNS,
         new TargetPatternSequence(patterns, policy, offset));
   }
@@ -50,8 +49,8 @@ public final class PrepareDepsOfPatternsValue implements SkyValue {
     private final FilteringPolicy policy;
     private final String offset;
 
-    public TargetPatternSequence(ImmutableList<String> patterns,
-        FilteringPolicy policy, String offset) {
+    private TargetPatternSequence(ImmutableList<String> patterns, FilteringPolicy policy,
+        String offset) {
       this.patterns = patterns;
       this.policy = policy;
       this.offset = offset;