Rewrite TargetPattern failure reporting

Report failures in TargetPatternFunction, rather than in its callers. Since we
can't distinguish between keep_going and nokeep_going modes, we otherwise end
up double-reporting errors. In the particular case that's covered by the
build_event_stream_test.sh, we end up reporting the same target pattern as both
skipped and failed.

Unfortunately, this means we cannot report whether the target pattern was
skipped or failed, so the pattern_skipped event is now unused (if we agree that
this is acceptable, I'll remove the corresponding infrastructure).

PiperOrigin-RevId: 199593700

1 files changed, 6 insertions, 0 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PatternExpandingError.java b/src/main/java/com/google/devtools/build/lib/skyframe/PatternExpandingError.java
index 99a76c840c..b6145a56b7 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/PatternExpandingError.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/PatternExpandingError.java
@@ -47,6 +47,12 @@ public final class PatternExpandingError implements BuildEvent {
     return new PatternExpandingError(pattern, message, false);
   }
 
+  public static PatternExpandingError failed(String term, String message) {
+    return new PatternExpandingError(ImmutableList.of(term), message, false);
+  }
+
+  // This is unused right now - when we generate the error, we don't know if we're in keep_going
+  // mode or not.
   public static PatternExpandingError skipped(String term, String message) {
     return new PatternExpandingError(ImmutableList.of(term), message, true);
   }