Add an intermediate SkyFunction for resolving the external package

The WORKSPACE file parsing needs to be separated into several parts
to enable load of labels in the WORKSPACE file.

This change adds an intermediate SkyFunction, ExternalPackageFunction,
that requires all the WORKSPACE file part to be parsed to resolve
//external: labels.

Issue #824 Step 1.

--
MOS_MIGRATED_REVID=113984026

1 files changed, 0 insertions, 7 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PackageValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/PackageValue.java
index 4e04eec827..01e4af54b4 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/PackageValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/PackageValue.java
@@ -19,7 +19,6 @@ import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe;
 import com.google.devtools.build.lib.packages.BuildFileContainsErrorsException;
 import com.google.devtools.build.lib.packages.Package;
 import com.google.devtools.build.lib.util.Preconditions;
-import com.google.devtools.build.lib.vfs.RootedPath;
 import com.google.devtools.build.skyframe.NotComparableSkyValue;
 import com.google.devtools.build.skyframe.SkyKey;
 
@@ -66,10 +65,4 @@ public class PackageValue implements NotComparableSkyValue {
     return keys;
   }
 
-  /**
-   * Returns a SkyKey to find the WORKSPACE file at the given path.
-   */
-  public static SkyKey workspaceKey(RootedPath workspacePath) {
-    return new SkyKey(SkyFunctions.WORKSPACE_FILE, workspacePath);
-  }
 }