diff options
author | Janak Ramakrishnan <janakr@google.com> | 2016-03-03 08:08:50 +0000 |
---|---|---|
committer | Kristina Chodorow <kchodorow@google.com> | 2016-03-03 15:27:55 +0000 |
commit | f745e99db7632cfb2145b6926f961e85f9084bc5 (patch) | |
tree | fbf6faf5c3bd701d551b0f27a2a04ab475a07ee9 /src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupValue.java | |
parent | 9b88920b70a1c0fafc5865b370d90a80ad7cae70 (diff) |
Use static creation method for SkyKey. This allows interning SkyKeys as they are created, as opposed to when they are requested from the ParallelEvaluator. That delay can lead to large memory spikes and churn.
--
MOS_MIGRATED_REVID=116224565
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupValue.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupValue.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupValue.java index d6fdcc00f2..816ab4fdcc 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupValue.java @@ -97,7 +97,7 @@ public abstract class PackageLookupValue implements SkyValue { } public static SkyKey key(PackageIdentifier pkgIdentifier) { - return new SkyKey(SkyFunctions.PACKAGE_LOOKUP, pkgIdentifier); + return SkyKey.create(SkyFunctions.PACKAGE_LOOKUP, pkgIdentifier); } private static class SuccessfulPackageLookupValue extends PackageLookupValue { |