aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
diff options
context:
space:
mode:
authorGravatar gregce <gregce@google.com>2018-02-15 15:30:07 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-02-15 15:32:07 -0800
commited1c6c21ef1d706e79252ce1e33d9c1283b889e1 (patch)
tree30d9a4f504271af4033a33e1a5913313dbab882a /src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
parent340b90205078599973f6f65d01bbb632f026b1f8 (diff)
Properly error when environment_group references non-existent targets.
Fixes #3911 PiperOrigin-RevId: 185912197
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
index 6114f1d933..af54d080c5 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
@@ -629,16 +629,16 @@ public class PackageFunction implements SkyFunction {
return null;
}
- Event.replayEventsOn(env.getListener(), pkgBuilder.getEvents());
- for (Postable post : pkgBuilder.getPosts()) {
- env.getListener().post(post);
- }
-
if (packageShouldBeConsideredInError) {
pkgBuilder.setContainsErrors();
}
Package pkg = pkgBuilder.finishBuild();
+ Event.replayEventsOn(env.getListener(), pkgBuilder.getEvents());
+ for (Postable post : pkgBuilder.getPosts()) {
+ env.getListener().post(post);
+ }
+
// We know this SkyFunction will not be called again, so we can remove the cache entry.
packageFunctionCache.invalidate(packageId);