diff options
author | 2017-06-27 17:58:35 +0200 | |
---|---|---|
committer | 2017-06-28 10:17:40 +0200 | |
commit | 3bc1547a5cd78bd6639d968b3cfddbe26b1c31d5 (patch) | |
tree | ad80da2596d9150632ca6a1f1510060fe849fa3a /src/main/java/com/google/devtools/build/lib/skyframe/LocalDiffAwareness.java | |
parent | 9b394a24dc65c794242e98a8a41eb8a60c78367b (diff) |
Add the default category and tag to all options.
Move the default from the annotation to every mention. This makes the incompleteness explicit. Will add the defaults to test targets in a separate change.
Once all dependencies are cleaned up, the Option annotation will no longer allow options without the documentationCategory or effectTag, to prevent new options being added without categories while we migrate to the new option categorization.
PiperOrigin-RevId: 160281252
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/LocalDiffAwareness.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/LocalDiffAwareness.java | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/LocalDiffAwareness.java b/src/main/java/com/google/devtools/build/lib/skyframe/LocalDiffAwareness.java index 4874d89d5c..882bc12d12 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/LocalDiffAwareness.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/LocalDiffAwareness.java @@ -24,7 +24,9 @@ import com.google.devtools.build.lib.util.Preconditions; import com.google.devtools.build.lib.vfs.ModifiedFileSet; import com.google.devtools.build.lib.vfs.PathFragment; import com.google.devtools.common.options.Option; +import com.google.devtools.common.options.OptionDocumentationCategory; import com.google.devtools.common.options.OptionsBase; +import com.google.devtools.common.options.proto.OptionFilters.OptionEffectTag; import java.io.IOException; import java.nio.file.FileSystems; import java.nio.file.Path; @@ -45,11 +47,14 @@ public abstract class LocalDiffAwareness implements DiffAwareness { */ public static final class Options extends OptionsBase { @Option( - name = "watchfs", - defaultValue = "false", - category = "server startup", - help = "If true, %{product} tries to use the operating system's file watch service for " - + "local changes instead of scanning every file for a change." + name = "watchfs", + defaultValue = "false", + category = "server startup", + documentationCategory = OptionDocumentationCategory.UNCATEGORIZED, + effectTags = {OptionEffectTag.UNKNOWN}, + help = + "If true, %{product} tries to use the operating system's file watch service for " + + "local changes instead of scanning every file for a change." ) public boolean watchFS; } |