Couple of Fileset micro-optimizations:

1. Prevent a redundant map.get() in SkyframeFilesetManifestAction#establishSkyframeDependencies
2. Make a more memory efficient FilesetEntrykey instead of reusing the LegacySkyKey.

RELNOTES: none
PiperOrigin-RevId: 171222499

1 files changed, 0 insertions, 15 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryValue.java
index 3ed1ecec0f..d9104ee57c 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryValue.java
@@ -13,14 +13,9 @@
 // limitations under the License.
 package com.google.devtools.build.lib.skyframe;
 
-import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSet;
 import com.google.devtools.build.lib.actions.FilesetOutputSymlink;
-import com.google.devtools.build.lib.actions.FilesetTraversalParams;
-import com.google.devtools.build.skyframe.LegacySkyKey;
-import com.google.devtools.build.skyframe.SkyKey;
 import com.google.devtools.build.skyframe.SkyValue;
-import java.util.stream.StreamSupport;
 
 /** Output symlinks produced by a whole FilesetEntry or by a single file in FilesetEntry.files. */
 public final class FilesetEntryValue implements SkyValue {
@@ -46,16 +41,6 @@ public final class FilesetEntryValue implements SkyValue {
     return symlinks;
   }
 
-  public static SkyKey key(FilesetTraversalParams params) {
-    return LegacySkyKey.create(SkyFunctions.FILESET_ENTRY, params);
-  }
-
-  public static ImmutableList<SkyKey> keys(Iterable<FilesetTraversalParams> paramsIterable) {
-    return StreamSupport.stream(paramsIterable.spliterator(), /*parallel=*/ false)
-        .map(FilesetEntryValue::key)
-        .collect(ImmutableList.toImmutableList());
-  }
-
   @Override
   public boolean equals(Object obj) {
     if (this == obj) {