aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java
diff options
context:
space:
mode:
authorGravatar kush <kush@google.com>2017-10-06 00:57:29 +0200
committerGravatar Klaus Aehlig <aehlig@google.com>2017-10-06 19:48:37 +0200
commitb0c1ac86804718e3aa0d3262d2e2cbe3f30f9ecb (patch)
tree6a96d66ca8431b8b439f54481de71f1eaf6e618f /src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java
parentb021cf4b0871247bb0ad2efb76b3fd91c98c94c8 (diff)
Couple of Fileset micro-optimizations:
1. Prevent a redundant map.get() in SkyframeFilesetManifestAction#establishSkyframeDependencies 2. Make a more memory efficient FilesetEntrykey instead of reusing the LegacySkyKey. RELNOTES: none PiperOrigin-RevId: 171222499
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java
index 064ab4ba65..e7a1b38972 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/FilesetEntryFunction.java
@@ -71,7 +71,7 @@ public final class FilesetEntryFunction implements SkyFunction {
// The absence of "direct" traversal indicates the presence of a "nested" fileset and
// getNestedTraversal will return the list FilesetTraversalParams corresponding to each
// FilesetEntry of the nested Fileset.
- ImmutableList<SkyKey> nestedKeys = FilesetEntryValue.keys(t.getNestedTraversal());
+ ImmutableList<SkyKey> nestedKeys = FilesetEntryKey.keys(t.getNestedTraversal());
Map<SkyKey, SkyValue> results = env.getValues(nestedKeys);
if (env.valuesMissing()) {
return null;