aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/CoverageReportFunction.java
diff options
context:
space:
mode:
authorGravatar tomlu <tomlu@google.com>2018-06-18 16:16:36 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-06-18 16:18:08 -0700
commit9e91f20bb31e44b4be836996ac9d91af61e1e822 (patch)
tree7e7c116290099ef5a8e16e67a9d4f5a0c908fbf9 /src/main/java/com/google/devtools/build/lib/skyframe/CoverageReportFunction.java
parentd4406d644efcf86327834a56b01cc212389e52e7 (diff)
Remove support for --discard_actions_after_execution.
The memory savings from this flag are not worth the complexity, and it interferes with action restarting. RELNOTES: Remove support for --discard_actions_after_execution. PiperOrigin-RevId: 201077905
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/CoverageReportFunction.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/CoverageReportFunction.java8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/CoverageReportFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/CoverageReportFunction.java
index b1e11dc0f1..c83069e327 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/CoverageReportFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/CoverageReportFunction.java
@@ -15,7 +15,6 @@
package com.google.devtools.build.lib.skyframe;
import com.google.common.base.Preconditions;
-import com.google.common.base.Supplier;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet;
import com.google.devtools.build.lib.actions.ActionAnalysisMetadata;
@@ -33,12 +32,9 @@ import com.google.devtools.build.skyframe.SkyValue;
*/
public class CoverageReportFunction implements SkyFunction {
private final ActionKeyContext actionKeyContext;
- private final Supplier<Boolean> removeActionsAfterEvaluation;
- CoverageReportFunction(
- ActionKeyContext actionKeyContext, Supplier<Boolean> removeActionsAfterEvaluation) {
+ CoverageReportFunction(ActionKeyContext actionKeyContext) {
this.actionKeyContext = actionKeyContext;
- this.removeActionsAfterEvaluation = Preconditions.checkNotNull(removeActionsAfterEvaluation);
}
@Override
@@ -67,7 +63,7 @@ public class CoverageReportFunction implements SkyFunction {
} catch (ActionConflictException e) {
throw new IllegalStateException("Action conflicts not expected in coverage: " + skyKey, e);
}
- return new CoverageReportValue(generatingActions, removeActionsAfterEvaluation.get());
+ return new CoverageReportValue(generatingActions);
}
@Override