diff options
author | 2018-02-11 09:23:55 -0800 | |
---|---|---|
committer | 2018-02-11 09:25:41 -0800 | |
commit | e45c0555cfb15ce403ff2f447edb74495a633ec1 (patch) | |
tree | 28c7a697306b91d00a49602b991aea9476c65892 /src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetKey.java | |
parent | e3bbfdb839a483f1a418a94d857c25794006fbe0 (diff) |
Add context argument to ObjectCodec.{serialize,deserialize}
Context implementations are currently empty, just doing the plumbing in this
change. Once this is in we can start passing along the ObjectCodecRegistry, which
will allow runtime codec resolution for classes not known at compile time.
We'll also inevitably add some memoization helpers, allowing us to optimize the
serialization process further.
PiperOrigin-RevId: 185305674
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetKey.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetKey.java | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetKey.java b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetKey.java index 166119f6a4..5cdf67cd31 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetKey.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetKey.java @@ -22,7 +22,9 @@ import com.google.devtools.build.lib.analysis.ConfiguredTarget; import com.google.devtools.build.lib.analysis.config.BuildConfiguration; import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.concurrent.BlazeInterners; +import com.google.devtools.build.lib.skyframe.serialization.DeserializationContext; import com.google.devtools.build.lib.skyframe.serialization.ObjectCodec; +import com.google.devtools.build.lib.skyframe.serialization.SerializationContext; import com.google.devtools.build.lib.skyframe.serialization.SerializationException; import com.google.devtools.build.skyframe.SkyFunctionName; import com.google.protobuf.CodedInputStream; @@ -211,24 +213,27 @@ public class ConfiguredTargetKey extends ActionLookupKey { } @Override - public void serialize(ConfiguredTargetKey obj, CodedOutputStream codedOut) + public void serialize( + SerializationContext context, ConfiguredTargetKey obj, CodedOutputStream codedOut) throws SerializationException, IOException { - Label.CODEC.serialize(obj.label, codedOut); + Label.CODEC.serialize(context, obj.label, codedOut); if (obj.configurationKey == null) { codedOut.writeBoolNoTag(false); } else { codedOut.writeBoolNoTag(true); - BuildConfigurationValue.Key.CODEC.serialize(obj.configurationKey, codedOut); + BuildConfigurationValue.Key.CODEC.serialize(context, obj.configurationKey, codedOut); } codedOut.writeBoolNoTag(obj.isHostConfiguration()); } @Override - public ConfiguredTargetKey deserialize(CodedInputStream codedIn) + public ConfiguredTargetKey deserialize(DeserializationContext context, CodedInputStream codedIn) throws SerializationException, IOException { return of( - Label.CODEC.deserialize(codedIn), - codedIn.readBool() ? BuildConfigurationValue.Key.CODEC.deserialize(codedIn) : null, + Label.CODEC.deserialize(context, codedIn), + codedIn.readBool() + ? BuildConfigurationValue.Key.CODEC.deserialize(context, codedIn) + : null, codedIn.readBool()); } } |