diff options
author | tomlu <tomlu@google.com> | 2018-06-18 16:16:36 -0700 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-06-18 16:18:08 -0700 |
commit | 9e91f20bb31e44b4be836996ac9d91af61e1e822 (patch) | |
tree | 7e7c116290099ef5a8e16e67a9d4f5a0c908fbf9 /src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java | |
parent | d4406d644efcf86327834a56b01cc212389e52e7 (diff) |
Remove support for --discard_actions_after_execution.
The memory savings from this flag are not worth the complexity, and it interferes with action restarting.
RELNOTES: Remove support for --discard_actions_after_execution.
PiperOrigin-RevId: 201077905
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java index 6949b6e613..71e1be16bb 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java @@ -14,7 +14,6 @@ package com.google.devtools.build.lib.skyframe; import com.google.common.base.Preconditions; -import com.google.common.base.Supplier; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; @@ -127,7 +126,6 @@ public final class ConfiguredTargetFunction implements SkyFunction { private final BuildViewProvider buildViewProvider; private final RuleClassProvider ruleClassProvider; private final Semaphore cpuBoundSemaphore; - private final Supplier<Boolean> removeActionsAfterEvaluation; private final BuildOptions defaultBuildOptions; /** * Indicates whether the set of packages transitively loaded for a given {@link @@ -142,14 +140,12 @@ public final class ConfiguredTargetFunction implements SkyFunction { BuildViewProvider buildViewProvider, RuleClassProvider ruleClassProvider, Semaphore cpuBoundSemaphore, - Supplier<Boolean> removeActionsAfterEvaluation, boolean storeTransitivePackagesForPackageRootResolution, boolean shouldUnblockCpuWorkWhenFetchingDeps, BuildOptions defaultBuildOptions) { this.buildViewProvider = buildViewProvider; this.ruleClassProvider = ruleClassProvider; this.cpuBoundSemaphore = cpuBoundSemaphore; - this.removeActionsAfterEvaluation = Preconditions.checkNotNull(removeActionsAfterEvaluation); this.storeTransitivePackagesForPackageRootResolution = storeTransitivePackagesForPackageRootResolution; this.shouldUnblockCpuWorkWhenFetchingDeps = shouldUnblockCpuWorkWhenFetchingDeps; @@ -808,8 +804,7 @@ public final class ConfiguredTargetFunction implements SkyFunction { ruleConfiguredTarget, transitivePackagesForPackageRootResolution == null ? null - : transitivePackagesForPackageRootResolution.build(), - removeActionsAfterEvaluation.get()); + : transitivePackagesForPackageRootResolution.build()); } else { GeneratingActions generatingActions; // Check for conflicting actions within this configured target (that indicates a bug in the @@ -827,8 +822,7 @@ public final class ConfiguredTargetFunction implements SkyFunction { generatingActions, transitivePackagesForPackageRootResolution == null ? null - : transitivePackagesForPackageRootResolution.build(), - removeActionsAfterEvaluation.get()); + : transitivePackagesForPackageRootResolution.build()); } } |