diff options
author | janakr <janakr@google.com> | 2018-03-10 06:48:59 -0800 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-03-10 06:50:28 -0800 |
commit | 9c101404519d91db8e8dec09f9a9495eb8352f58 (patch) | |
tree | d2689acedd5ce2474ea89089aa8651be00c6a485 /src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java | |
parent | 50f99d56bb710f01524bd3f04882dada16a792c3 (diff) |
Add BuildConfiguration to ConfiguredTargetAndTarget and rename it to ConfiguredTargetAndData. We want to get BuildConfiguration out of ConfiguredTarget because it uses >800K when serialized.
PiperOrigin-RevId: 188600002
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java index 42b32c98ca..ea70f6ebdc 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java @@ -258,7 +258,7 @@ public final class ConfiguredTargetFunction implements SkyFunction { } // Calculate the dependencies of this target. - OrderedSetMultimap<Attribute, ConfiguredTargetAndTarget> depValueMap = + OrderedSetMultimap<Attribute, ConfiguredTargetAndData> depValueMap = computeDependencies( env, resolver, @@ -382,7 +382,7 @@ public final class ConfiguredTargetFunction implements SkyFunction { * the host configuration as early as possible and pass this reference to all consumers */ @Nullable - static OrderedSetMultimap<Attribute, ConfiguredTargetAndTarget> computeDependencies( + static OrderedSetMultimap<Attribute, ConfiguredTargetAndData> computeDependencies( Environment env, SkyframeDependencyResolver resolver, TargetAndConfiguration ctgValue, @@ -432,7 +432,7 @@ public final class ConfiguredTargetFunction implements SkyFunction { } // Resolve configured target dependencies and handle errors. - Map<SkyKey, ConfiguredTargetAndTarget> depValues = + Map<SkyKey, ConfiguredTargetAndData> depValues = resolveConfiguredTargetDependencies( env, depValueNames.values(), @@ -522,7 +522,7 @@ public final class ConfiguredTargetFunction implements SkyFunction { } configValueNames = staticConfigs.build(); - Map<SkyKey, ConfiguredTargetAndTarget> configValues = + Map<SkyKey, ConfiguredTargetAndData> configValues = resolveConfiguredTargetDependencies( env, configValueNames, @@ -555,12 +555,12 @@ public final class ConfiguredTargetFunction implements SkyFunction { /** * Resolves the targets referenced in depValueNames and returns their {@link - * ConfiguredTargetAndTarget} instances. + * ConfiguredTargetAndData} instances. * * <p>Returns null if not all instances are available yet. */ @Nullable - private static Map<SkyKey, ConfiguredTargetAndTarget> resolveConfiguredTargetDependencies( + private static Map<SkyKey, ConfiguredTargetAndData> resolveConfiguredTargetDependencies( Environment env, Collection<Dependency> deps, @Nullable NestedSetBuilder<Package> transitivePackagesForPackageRootResolution, @@ -582,7 +582,7 @@ public final class ConfiguredTargetFunction implements SkyFunction { deps, input -> PackageValue.key(input.getLabel().getPackageIdentifier()))); Map<SkyKey, ValueOrException<ConfiguredValueCreationException>> depValuesOrExceptions = env.getValuesOrThrow(depKeys, ConfiguredValueCreationException.class); - Map<SkyKey, ConfiguredTargetAndTarget> result = Maps.newHashMapWithExpectedSize(deps.size()); + Map<SkyKey, ConfiguredTargetAndData> result = Maps.newHashMapWithExpectedSize(deps.size()); Set<SkyKey> aliasPackagesToFetch = new HashSet<>(); List<Dependency> aliasDepsToRedo = new ArrayList<>(); Map<SkyKey, SkyValue> aliasPackageValues = null; @@ -629,9 +629,10 @@ public final class ConfiguredTargetFunction implements SkyFunction { try { result.put( key, - new ConfiguredTargetAndTarget( + new ConfiguredTargetAndData( depValue.getConfiguredTarget(), - pkgValue.getPackage().getTarget(depLabel.getName()))); + pkgValue.getPackage().getTarget(depLabel.getName()), + depValue.getConfiguredTarget().getConfiguration())); } catch (NoSuchTargetException e) { throw new IllegalStateException("Target already verified for " + dep, e); } @@ -676,7 +677,7 @@ public final class ConfiguredTargetFunction implements SkyFunction { Environment env, Target target, BuildConfiguration configuration, - OrderedSetMultimap<Attribute, ConfiguredTargetAndTarget> depValueMap, + OrderedSetMultimap<Attribute, ConfiguredTargetAndData> depValueMap, ImmutableMap<Label, ConfigMatchingProvider> configConditions, @Nullable ToolchainContext toolchainContext, @Nullable NestedSetBuilder<Package> transitivePackagesForPackageRootResolution) |