diff options
author | 2018-02-11 09:23:55 -0800 | |
---|---|---|
committer | 2018-02-11 09:25:41 -0800 | |
commit | e45c0555cfb15ce403ff2f447edb74495a633ec1 (patch) | |
tree | 28c7a697306b91d00a49602b991aea9476c65892 /src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationFragmentValue.java | |
parent | e3bbfdb839a483f1a418a94d857c25794006fbe0 (diff) |
Add context argument to ObjectCodec.{serialize,deserialize}
Context implementations are currently empty, just doing the plumbing in this
change. Once this is in we can start passing along the ObjectCodecRegistry, which
will allow runtime codec resolution for classes not known at compile time.
We'll also inevitably add some memoization helpers, allowing us to optimize the
serialization process further.
PiperOrigin-RevId: 185305674
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationFragmentValue.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationFragmentValue.java | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationFragmentValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationFragmentValue.java index 3ec99dbcd1..c81f29c55d 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationFragmentValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/ConfigurationFragmentValue.java @@ -23,8 +23,10 @@ import com.google.devtools.build.lib.concurrent.BlazeInterners; import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable; import com.google.devtools.build.lib.concurrent.ThreadSafety.ThreadSafe; import com.google.devtools.build.lib.packages.RuleClassProvider; +import com.google.devtools.build.lib.skyframe.serialization.DeserializationContext; import com.google.devtools.build.lib.skyframe.serialization.InjectingObjectCodec; import com.google.devtools.build.lib.skyframe.serialization.ObjectCodec; +import com.google.devtools.build.lib.skyframe.serialization.SerializationContext; import com.google.devtools.build.lib.skyframe.serialization.SerializationException; import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.build.lib.skyframe.serialization.strings.StringCodecs; @@ -137,22 +139,24 @@ public class ConfigurationFragmentValue implements SkyValue { } @Override - public void serialize(ConfigurationFragmentKey obj, CodedOutputStream codedOut) + public void serialize( + SerializationContext context, ConfigurationFragmentKey obj, CodedOutputStream codedOut) throws SerializationException, IOException { - BuildOptions.CODEC.serialize(obj.buildOptions, codedOut); - StringCodecs.asciiOptimized().serialize(obj.fragmentType.getName(), codedOut); + BuildOptions.CODEC.serialize(context, obj.buildOptions, codedOut); + StringCodecs.asciiOptimized().serialize(context, obj.fragmentType.getName(), codedOut); } @SuppressWarnings("unchecked") // Cast to Class<? extends Fragment>. @Override - public ConfigurationFragmentKey deserialize(CodedInputStream codedIn) + public ConfigurationFragmentKey deserialize( + DeserializationContext context, CodedInputStream codedIn) throws SerializationException, IOException { try { return of( - BuildOptions.CODEC.deserialize(codedIn), + BuildOptions.CODEC.deserialize(context, codedIn), (Class<? extends Fragment>) - Class.forName(StringCodecs.asciiOptimized().deserialize(codedIn))); + Class.forName(StringCodecs.asciiOptimized().deserialize(context, codedIn))); } catch (ClassNotFoundException e) { throw new SerializationException("Couldn't deserialize ConfigurationFragmentKey", e); } |