Remove ConfiguredTarget from TargetCompletionValue, since it is no longer needed: we can get the ConfiguredTargetKey directly from the TargetCompletionKey. Since that was the only use of the actual value in EvaluationProgressReceiver#evaluated, remove it, instead just provide a boolean enum that gives whether or not evaluation succeeded.

PiperOrigin-RevId: 199178047

1 files changed, 6 insertions, 8 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java
index 83e879994f..de70aa1af0 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java
@@ -79,10 +79,8 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S
     MissingInputFileException getMissingFilesException(
         TValue value, int missingCount, Environment env) throws InterruptedException;
 
-    /**
-     * Creates a successful completion value.
-     */
-    TResult createResult(TValue value);
+    /** Provides a successful completion value. */
+    TResult getResult();
 
     /** Creates a failed completion value. */
     ExtendedEventHandler.Postable createFailed(
@@ -157,8 +155,8 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S
     }
 
     @Override
-    public TargetCompletionValue createResult(ConfiguredTargetValue value) {
-      return new TargetCompletionValue(value.getConfiguredTarget());
+    public TargetCompletionValue getResult() {
+      return TargetCompletionValue.INSTANCE;
     }
 
     @Override
@@ -251,7 +249,7 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S
     }
 
     @Override
-    public AspectCompletionValue createResult(AspectValue value) {
+    public AspectCompletionValue getResult() {
       return AspectCompletionValue.INSTANCE;
     }
 
@@ -369,7 +367,7 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S
       return null;
     }
     env.getListener().post(postable);
-    return completor.createResult(value);
+    return completor.getResult();
   }
 
   @Override