diff options
| author |  janakr <janakr@google.com> | 2018-01-11 14:02:35 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-01-11 14:04:37 -0800 |
| commit | 573807d4e9d1b7a8b6956278773dfc53b544093f (patch) | |
| tree | ce89c3a760afbb113f78621a2b1ef0cbb9cef5e5 /src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java | |
| parent | 42623f59fdd3bfbdfc21490c69f21537fa32011c (diff) | |
Convert ActionLookupKey implementations to directly implement SkyKey, removing the layer of indirection of getting SkyKey out of ActionLookupKey, which uses more memory for no reason.
PiperOrigin-RevId: 181658615
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java index 02bb53fd10..db8d44ccc2 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java @@ -103,8 +103,7 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S public ConfiguredTargetValue getValueFromSkyKey(SkyKey skyKey, Environment env) throws InterruptedException { TargetCompletionKey tcKey = (TargetCompletionKey) skyKey.argument(); - ConfiguredTargetKey lac = tcKey.configuredTargetKey(); - return (ConfiguredTargetValue) env.getValue(lac.getSkyKey()); + return (ConfiguredTargetValue) env.getValue(tcKey.configuredTargetKey()); } @Override @@ -179,7 +178,7 @@ public final class CompletionFunction<TValue extends SkyValue, TResult extends S throws InterruptedException { AspectCompletionKey acKey = (AspectCompletionKey) skyKey.argument(); AspectKey aspectKey = acKey.aspectKey(); - return (AspectValue) env.getValue(aspectKey.getSkyKey()); + return (AspectValue) env.getValue(aspectKey); } @Override |