diff options
author | 2018-02-11 09:23:55 -0800 | |
---|---|---|
committer | 2018-02-11 09:25:41 -0800 | |
commit | e45c0555cfb15ce403ff2f447edb74495a633ec1 (patch) | |
tree | 28c7a697306b91d00a49602b991aea9476c65892 /src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java | |
parent | e3bbfdb839a483f1a418a94d857c25794006fbe0 (diff) |
Add context argument to ObjectCodec.{serialize,deserialize}
Context implementations are currently empty, just doing the plumbing in this
change. Once this is in we can start passing along the ObjectCodecRegistry, which
will allow runtime codec resolution for classes not known at compile time.
We'll also inevitably add some memoization helpers, allowing us to optimize the
serialization process further.
PiperOrigin-RevId: 185305674
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java | 26 |
1 files changed, 14 insertions, 12 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java index 0aca54b402..cf12d6220d 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java @@ -35,8 +35,10 @@ import com.google.devtools.build.lib.packages.AspectParameters; import com.google.devtools.build.lib.packages.Package; import com.google.devtools.build.lib.skyframe.BuildConfigurationValue.Key; import com.google.devtools.build.lib.skyframe.ConfiguredTargetKey.KeyAndHost; +import com.google.devtools.build.lib.skyframe.serialization.DeserializationContext; import com.google.devtools.build.lib.skyframe.serialization.ImmutableListCodec; import com.google.devtools.build.lib.skyframe.serialization.ObjectCodec; +import com.google.devtools.build.lib.skyframe.serialization.SerializationContext; import com.google.devtools.build.lib.skyframe.serialization.SerializationException; import com.google.devtools.build.lib.syntax.SkylarkImport; import com.google.devtools.build.skyframe.SkyFunctionName; @@ -277,25 +279,25 @@ public final class AspectValue extends ActionLookupValue { } @Override - public void serialize(AspectKey obj, CodedOutputStream codedOut) + public void serialize(SerializationContext context, AspectKey obj, CodedOutputStream codedOut) throws SerializationException, IOException { - Label.CODEC.serialize(obj.label, codedOut); - ConfiguredTargetKey.CODEC.serialize(obj.baseConfiguredTargetKey, codedOut); - listCodec.serialize(obj.baseKeys, codedOut); - AspectDescriptor.CODEC.serialize(obj.aspectDescriptor, codedOut); - Key.CODEC.serialize(obj.aspectConfigurationKey, codedOut); + Label.CODEC.serialize(context, obj.label, codedOut); + ConfiguredTargetKey.CODEC.serialize(context, obj.baseConfiguredTargetKey, codedOut); + listCodec.serialize(context, obj.baseKeys, codedOut); + AspectDescriptor.CODEC.serialize(context, obj.aspectDescriptor, codedOut); + Key.CODEC.serialize(context, obj.aspectConfigurationKey, codedOut); codedOut.writeBoolNoTag(obj.aspectConfigurationIsHost()); } @Override - public AspectKey deserialize(CodedInputStream codedIn) + public AspectKey deserialize(DeserializationContext context, CodedInputStream codedIn) throws SerializationException, IOException { return createAspectKey( - Label.CODEC.deserialize(codedIn), - ConfiguredTargetKey.CODEC.deserialize(codedIn), - listCodec.deserialize(codedIn), - AspectDescriptor.CODEC.deserialize(codedIn), - Key.CODEC.deserialize(codedIn), + Label.CODEC.deserialize(context, codedIn), + ConfiguredTargetKey.CODEC.deserialize(context, codedIn), + listCodec.deserialize(context, codedIn), + AspectDescriptor.CODEC.deserialize(context, codedIn), + Key.CODEC.deserialize(context, codedIn), codedIn.readBool()); } } |