aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/runtime
diff options
context:
space:
mode:
authorGravatar Ulf Adams <ulfjack@google.com>2016-08-10 09:06:50 +0000
committerGravatar Yue Gan <yueg@google.com>2016-08-10 13:54:51 +0000
commit7e71f89f5ac0ef826fc1b9474155197946b031d3 (patch)
treee7079106360d91407e51291c871c796a4b45e5e3 /src/main/java/com/google/devtools/build/lib/runtime
parentea46dfc52c4142d7b30dbac36b365ffa7ea6b338 (diff)
Cleanup BlazeRuntime and ServerBuilder slightly.
-- MOS_MIGRATED_REVID=129843837
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/runtime')
-rw-r--r--src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java9
-rw-r--r--src/main/java/com/google/devtools/build/lib/runtime/ServerBuilder.java3
2 files changed, 5 insertions, 7 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java b/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java
index 4362c005cb..acc7e6a06b 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java
@@ -20,7 +20,6 @@ import com.google.common.base.Predicates;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
-import com.google.common.collect.Sets;
import com.google.common.eventbus.SubscriberExceptionContext;
import com.google.common.eventbus.SubscriberExceptionHandler;
import com.google.common.util.concurrent.Futures;
@@ -80,7 +79,6 @@ import com.google.devtools.common.options.OptionsParser;
import com.google.devtools.common.options.OptionsParsingException;
import com.google.devtools.common.options.OptionsProvider;
import com.google.devtools.common.options.TriState;
-
import java.io.BufferedOutputStream;
import java.io.IOException;
import java.io.OutputStream;
@@ -93,7 +91,6 @@ import java.util.LinkedHashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
-import java.util.Set;
import java.util.UUID;
import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;
@@ -103,7 +100,6 @@ import java.util.logging.Level;
import java.util.logging.LogRecord;
import java.util.logging.Logger;
import java.util.regex.Pattern;
-
import javax.annotation.Nullable;
/**
@@ -824,8 +820,9 @@ public final class BlazeRuntime {
*/
private static OptionsProvider parseOptions(
Iterable<BlazeModule> modules, List<String> args) throws OptionsParsingException {
- Set<Class<? extends OptionsBase>> optionClasses = Sets.newHashSet();
- optionClasses.addAll(BlazeCommandUtils.getStartupOptions(modules));
+ ImmutableList<Class<? extends OptionsBase>> optionClasses =
+ BlazeCommandUtils.getStartupOptions(modules);
+
// First parse the command line so that we get the option_sources argument
OptionsParser parser = OptionsParser.newOptionsParser(optionClasses);
parser.setAllowResidue(false);
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/ServerBuilder.java b/src/main/java/com/google/devtools/build/lib/runtime/ServerBuilder.java
index 3a7a3a2371..d99e22c352 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/ServerBuilder.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/ServerBuilder.java
@@ -107,7 +107,8 @@ public final class ServerBuilder {
}
/** Adds the given commands to the server. */
- public void addCommands(BlazeCommand... commands) {
+ public ServerBuilder addCommands(BlazeCommand... commands) {
this.commands.add(commands);
+ return this;
}
}