aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/runtime
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2018-01-17 14:18:02 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-01-17 14:20:36 -0800
commit4695de623614b1105166513d28f6b52ceb8f4c83 (patch)
tree074bb26d04bebe75e622b01a0b73bdfd617d77e1 /src/main/java/com/google/devtools/build/lib/runtime
parentaadf6600faa099726b2e1c00e75b0edc9d95bfb8 (diff)
Add deprecation warning message to mobile-install classic mode.
We've notified the top classic users by email that classic mode is deprecated. As we are no longer actively supporting classic mode, we'd like users to move over to skylark. RELNOTES: None. PiperOrigin-RevId: 182268733
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/runtime')
-rw-r--r--src/main/java/com/google/devtools/build/lib/runtime/mobileinstall/MobileInstallCommand.java6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/mobileinstall/MobileInstallCommand.java b/src/main/java/com/google/devtools/build/lib/runtime/mobileinstall/MobileInstallCommand.java
index 0f297c2e1e..acdd49784d 100644
--- a/src/main/java/com/google/devtools/build/lib/runtime/mobileinstall/MobileInstallCommand.java
+++ b/src/main/java/com/google/devtools/build/lib/runtime/mobileinstall/MobileInstallCommand.java
@@ -172,6 +172,12 @@ public class MobileInstallCommand implements BlazeCommand {
WriteAdbArgsAction.Options adbOptions = options.getOptions(WriteAdbArgsAction.Options.class);
if (mobileInstallOptions.mode == Mode.CLASSIC) {
+ // Notify internal users that classic mode is deprecated. Use mobile_install_aspect as a proxy
+ // for internal vs external users.
+ if (!mobileInstallOptions.mobileInstallAspect.startsWith("@")) {
+ env.getReporter().handle(Event.warn(
+ "mobile-install --mode=classic is deprecated. This option will go away soon."));
+ }
if (adbOptions.start == StartType.WARM && !mobileInstallOptions.incremental) {
env.getReporter().handle(Event.warn(
"Warm start is enabled, but will have no effect on a non-incremental build"));