diff options
author | 2016-04-20 15:13:51 +0000 | |
---|---|---|
committer | 2016-04-21 10:57:42 +0000 | |
commit | 3c9a2265ea043c52c81951907fbc626b8c03add4 (patch) | |
tree | 8b164b31b2b8d7bd13538bb8eed4581cc6abcc51 /src/main/java/com/google/devtools/build/lib/runtime | |
parent | 6d26ceba17d6a9577d2c1fa3ff4f8a4516a40ec2 (diff) |
Make client-provided options an rc source
The client provides information about whether the terminal is a tty, and
which width the output should be formatted for. Passing this information
as explicit command-line arguments has the disadvantage that it overrides
any setting in configuration files. While usually there is no one-size-fits-all
value for terminal width, it doesn't make sense either to have an option
where the user cannot set a default. Fix this by providing the client options
as least imported rc-source.
This is a roll-forward of commit 044adedc70de040475443e52eb1a3c692159790e
--
MOS_MIGRATED_REVID=120338148
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/runtime')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java b/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java index 707aabe259..5f288d7487 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java +++ b/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java @@ -533,9 +533,10 @@ public class BlazeCommandDispatcher { throws OptionsParsingException { if (!rcfileOptions.isEmpty()) { String inherited = commandToParse.equals(originalCommand) ? "" : "Inherited "; - rcfileNotes.add("Reading options for '" + originalCommand + - "' from " + rcfile + ":\n" + - " " + inherited + "'" + commandToParse + "' options: " + String source = rcfile.equals("client") ? "Options provided by the client" + : "Reading options for '" + originalCommand + "' from " + rcfile; + rcfileNotes.add(source + ":\n" + + " " + inherited + "'" + commandToParse + "' options: " + Joiner.on(' ').join(rcfileOptions)); optionsParser.parse(OptionPriority.RC_FILE, rcfile, rcfileOptions); } |