diff options
author | ccalvarin <ccalvarin@google.com> | 2017-06-27 17:58:35 +0200 |
---|---|---|
committer | Marcel Hlopko <hlopko@google.com> | 2017-06-28 10:17:40 +0200 |
commit | 3bc1547a5cd78bd6639d968b3cfddbe26b1c31d5 (patch) | |
tree | ad80da2596d9150632ca6a1f1510060fe849fa3a /src/main/java/com/google/devtools/build/lib/runtime/commands/InfoCommand.java | |
parent | 9b394a24dc65c794242e98a8a41eb8a60c78367b (diff) |
Add the default category and tag to all options.
Move the default from the annotation to every mention. This makes the incompleteness explicit. Will add the defaults to test targets in a separate change.
Once all dependencies are cleaned up, the Option annotation will no longer allow options without the documentationCategory or effectTag, to prevent new options being added without categories while we migrate to the new option categorization.
PiperOrigin-RevId: 160281252
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/runtime/commands/InfoCommand.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/runtime/commands/InfoCommand.java | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/commands/InfoCommand.java b/src/main/java/com/google/devtools/build/lib/runtime/commands/InfoCommand.java index 27eb32c3fc..802d18c1d9 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/commands/InfoCommand.java +++ b/src/main/java/com/google/devtools/build/lib/runtime/commands/InfoCommand.java @@ -28,9 +28,11 @@ import com.google.devtools.build.lib.util.AbruptExitException; import com.google.devtools.build.lib.util.ExitCode; import com.google.devtools.build.lib.util.io.OutErr; import com.google.devtools.common.options.Option; +import com.google.devtools.common.options.OptionDocumentationCategory; import com.google.devtools.common.options.OptionsBase; import com.google.devtools.common.options.OptionsParser; import com.google.devtools.common.options.OptionsProvider; +import com.google.devtools.common.options.proto.OptionFilters.OptionEffectTag; import java.io.IOException; import java.nio.charset.StandardCharsets; import java.util.List; @@ -61,10 +63,14 @@ import java.util.TreeMap; public class InfoCommand implements BlazeCommand { public static class Options extends OptionsBase { - @Option(name = "show_make_env", - defaultValue = "false", - category = "misc", - help = "Include the \"Make\" environment in the output.") + @Option( + name = "show_make_env", + defaultValue = "false", + category = "misc", + documentationCategory = OptionDocumentationCategory.UNCATEGORIZED, + effectTags = {OptionEffectTag.UNKNOWN}, + help = "Include the \"Make\" environment in the output." + ) public boolean showMakeEnvironment; } |