diff options
author | Klaus Aehlig <aehlig@google.com> | 2016-04-18 10:40:08 +0000 |
---|---|---|
committer | Damien Martin-Guillerez <dmarting@google.com> | 2016-04-18 14:56:36 +0000 |
commit | a181c927a4f3e116030079d7a6b2fa8a92885501 (patch) | |
tree | c3150ccb82eea1a8b988b00d7fa98ecbd45b81b4 /src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java | |
parent | edeb753a29ad828d26ff217a799a653bb01df31c (diff) |
experimental UI: avoid empty lines between one-line FAILURE notes
When reporting a multi-line test-failure message (the test that failed,
plus the paths to the log files) to the scrollback buffer, it makes sense
to end this whole block by an empty line. If, however, the test failure
does not report any logs (e.g., if the build was interrupted), the next
scroll-back buffer line can follow immediately to keep the scroll-back
buffer more compact.
--
Change-Id: I59d8ba9416d0a9bcbc8d959fee21cc94fa89018e
Reviewed-on: https://bazel-review.googlesource.com/#/c/3386
MOS_MIGRATED_REVID=120108504
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java b/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java index 57e3775351..ee0e542ece 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java +++ b/src/main/java/com/google/devtools/build/lib/runtime/ExperimentalEventHandler.java @@ -263,7 +263,9 @@ public class ExperimentalEventHandler extends BlazeCommandEventHandler { terminal.writeString(" " + logPath.getPathString()); crlf(); } - crlf(); + if (summary.getFailedLogs().size() > 0) { + crlf(); + } if (cursorControl) { addProgressBar(); } |