diff options
| author |  ccalvarin <ccalvarin@google.com> | 2018-03-30 08:11:14 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-03-30 08:12:57 -0700 |
| commit | 520c66fc48ae054807d969354fad6cdfcac45721 (patch) | |
| tree | 51f791a3eeebf94a60f897acc986b310131621bc /src/main/java/com/google/devtools/build/lib/rules | |
| parent | e8bed799d59526541afa2a0e9ef5d4c49e3ba390 (diff) | |
Make the client's java startup command line list all startup options.
We expect that the client passes all startup options to the server, default or explicit. The server's listing of default values should not matter. Yet for a number of these options, the default value in the server was relied upon, because the server command line was not constructed with the client's default value included. Fix visible cases of this, long term this should be tested for, so the invariant is not broken again.
This has been the documented expectation for a long time, but a number of violations have crept up over time. Update the comments that lead to this expectation to be more realistic.
Add debug statement that shows which options are changed when startup options cause the server to be restarted. The detailed logs will only be seen if --client_debug is set to TRUE.
RELNOTES: None.
PiperOrigin-RevId: 191066983
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules')
0 files changed, 0 insertions, 0 deletions