diff options
author | Greg Estren <gregce@google.com> | 2015-05-12 20:39:07 +0000 |
---|---|---|
committer | Damien Martin-Guillerez <dmarting@google.com> | 2015-05-15 09:40:29 +0000 |
commit | 497ef110c344b2a309210339f125916f355530f9 (patch) | |
tree | 3775f52a34911c1a364e142f8fccb4ea86328d46 /src/main/java/com/google/devtools/build/lib/rules | |
parent | 71d843f41b0e968dca1d2b2b192265505a3eb7b1 (diff) |
Refine duplicate label checking for embedded selects. Before, we were
coarsely checking for duplicates *anywhere*, e.g.:
select({':a': ['a.cc'], ':b': ['a.cc']}) + select({':a': ['b.cc'], ':b': ['b.cc']})
would fail. But this case is okay because these duplicates are in mutually
exclusive select paths (so they could never appear together anyway).
The new checking logic is:
- Duplicates can appear in different paths of the same select.
- Duplicates can *not* appear within the same path of a select.
- Duplicates can *not* appear across multiple selects (no matter what path -
this is still stricter than we need to be, but there's no strong case
for refining this case now).
--
MOS_MIGRATED_REVID=93447979
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules')
0 files changed, 0 insertions, 0 deletions