Cleanup SolibSymlinkAction: "target" is never null, and no need to re-implement what we get for free in the base class.

RELNOTES: None
PiperOrigin-RevId: 155080289

1 files changed, 1 insertions, 24 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/SolibSymlinkAction.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/SolibSymlinkAction.java
index e524b1e12c..9d564d551d 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/SolibSymlinkAction.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/SolibSymlinkAction.java
@@ -28,7 +28,6 @@ import com.google.devtools.build.lib.analysis.config.BuildConfiguration;
 import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable;
 import com.google.devtools.build.lib.util.Fingerprint;
 import com.google.devtools.build.lib.util.Preconditions;
-import com.google.devtools.build.lib.vfs.FileSystemUtils;
 import com.google.devtools.build.lib.vfs.Path;
 import com.google.devtools.build.lib.vfs.PathFragment;
 import java.io.IOException;
@@ -43,7 +42,6 @@ import java.io.IOException;
  */
 @Immutable
 public final class SolibSymlinkAction extends AbstractAction {
-  private final Artifact library;
   private final Path target;
   private final Artifact symlink;
 
@@ -51,25 +49,15 @@ public final class SolibSymlinkAction extends AbstractAction {
     super(owner, ImmutableList.of(library), ImmutableList.of(symlink));
 
     Preconditions.checkArgument(Link.SHARED_LIBRARY_FILETYPES.matches(library.getFilename()));
-    this.library = Preconditions.checkNotNull(library);
     this.symlink = Preconditions.checkNotNull(symlink);
     this.target = library.getPath();
   }
 
   @Override
-  protected void deleteOutputs(Path execRoot) throws IOException {
-    // Do not delete outputs if action does not intend to do anything.
-    if (target != null) {
-      super.deleteOutputs(execRoot);
-    }
-  }
-
-  @Override
   public void execute(
       ActionExecutionContext actionExecutionContext) throws ActionExecutionException {
     Path mangledPath = symlink.getPath();
     try {
-      FileSystemUtils.createDirectoryAndParents(mangledPath.getParentDirectory());
       mangledPath.createSymbolicLink(target);
     } catch (IOException e) {
       throw new ActionExecutionException("failed to create _solib symbolic link '"
@@ -77,23 +65,12 @@ public final class SolibSymlinkAction extends AbstractAction {
     }
   }
 
-  @Override
-  public Artifact getPrimaryInput() {
-    return library;
-  }
-
-  @Override
-  public Artifact getPrimaryOutput() {
-    return symlink;
-  }
 
   @Override
   protected String computeKey() {
     Fingerprint f = new Fingerprint();
     f.addPath(symlink.getPath());
-    if (target != null) {
-      f.addPath(target);
-    }
+    f.addPath(target);
     return f.hexDigestAndReset();
   }