diff options
author | Florian Weikert <fwe@google.com> | 2015-08-05 17:03:20 +0000 |
---|---|---|
committer | Florian Weikert <fwe@google.com> | 2015-08-05 20:54:46 +0000 |
commit | 24866017148451fc468d90673d944c8fd99e1977 (patch) | |
tree | 17e922df59299574247b5cebd24c82e45da29cbe /src/main/java/com/google/devtools/build/lib/rules | |
parent | dd16491b5e6d32f78687d415acc7872da4b3656c (diff) |
Removed BuildConfiguration.Fragment#getName() and #isSkylarkVisible().
Instead, the SkylarkModule annotation is being used to identify fragments that are visible in Skylark.
--
MOS_MIGRATED_REVID=99930512
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules')
3 files changed, 1 insertions, 31 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java index b410f7e691..f72c4f34c0 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java @@ -663,16 +663,6 @@ public class CppConfiguration extends BuildConfiguration.Fragment { this.additionalMakeVariables = ImmutableMap.copyOf(makeVariablesBuilder); } - @Override - public boolean isSkylarkVisible() { - return true; - } - - @Override - public String getName() { - return "cpp"; - } - private List<OptionalFlag> convertOptionalOptions( List<CrosstoolConfig.CToolchain.OptionalFlag> optionalFlagList) throws IllegalArgumentException { diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java index 71454c6ef5..2151bffc2c 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaConfiguration.java @@ -34,7 +34,7 @@ import java.util.List; * A java compiler configuration containing the flags required for compilation. */ @Immutable -@SkylarkModule(name = "java_configuration", doc = "A java compiler configuration") +@SkylarkModule(name = "java", doc = "A java compiler configuration") public final class JavaConfiguration extends Fragment { /** * Values for the --experimental_java_classpath option @@ -104,16 +104,6 @@ public final class JavaConfiguration extends Fragment { } this.translationTargets = translationsBuilder.build(); } - - @Override - public boolean isSkylarkVisible() { - return true; - } - - @Override - public String getName() { - return "java"; - } @SkylarkCallable(name = "default_javac_flags", structField = true, doc = "The default flags for the Java compiler.") diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/Jvm.java b/src/main/java/com/google/devtools/build/lib/rules/java/Jvm.java index 378dc60462..d822da836c 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/java/Jvm.java +++ b/src/main/java/com/google/devtools/build/lib/rules/java/Jvm.java @@ -46,16 +46,6 @@ public final class Jvm extends BuildConfiguration.Fragment { this.javaHome = javaHome; this.jvmLabel = jvmLabel; } - - @Override - public boolean isSkylarkVisible() { - return true; - } - - @Override - public String getName() { - return "jvm"; - } @Override public void addImplicitLabels(Multimap<String, Label> implicitLabels) { |