aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/python/PyLibrary.java
diff options
context:
space:
mode:
authorGravatar plf <plf@google.com>2018-06-07 05:19:16 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-06-07 05:20:48 -0700
commitf137cea0ac74334013e7b064e59d1624cf032ac4 (patch)
treed83d46acef5baa828113e5373f44eaefa82f6b63 /src/main/java/com/google/devtools/build/lib/rules/python/PyLibrary.java
parent6b1635279e8b33dc1ac505ac81825e38f8797a14 (diff)
C++: Refactors PyWrapCc to make it easier to migrate to Skylark
RELNOTES:none PiperOrigin-RevId: 199619637
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/python/PyLibrary.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/python/PyLibrary.java21
1 files changed, 2 insertions, 19 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/python/PyLibrary.java b/src/main/java/com/google/devtools/build/lib/rules/python/PyLibrary.java
index 97060f345c..1d8c7ec6d7 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/python/PyLibrary.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/python/PyLibrary.java
@@ -25,10 +25,6 @@ import com.google.devtools.build.lib.analysis.configuredtargets.RuleConfiguredTa
import com.google.devtools.build.lib.collect.nestedset.NestedSet;
import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder;
import com.google.devtools.build.lib.collect.nestedset.Order;
-import com.google.devtools.build.lib.rules.cpp.AbstractCcLinkParamsStore;
-import com.google.devtools.build.lib.rules.cpp.CcLinkParams;
-import com.google.devtools.build.lib.rules.cpp.CcLinkParamsStore;
-import com.google.devtools.build.lib.rules.cpp.CcLinkingInfo;
import com.google.devtools.build.lib.vfs.PathFragment;
import java.util.ArrayList;
import java.util.List;
@@ -64,17 +60,6 @@ public abstract class PyLibrary implements RuleConfiguredTargetFactory {
NestedSetBuilder.wrap(Order.STABLE_ORDER, allOutputs);
common.addPyExtraActionPseudoAction();
- AbstractCcLinkParamsStore ccLinkParamsStore =
- new AbstractCcLinkParamsStore() {
- @Override
- protected void collect(
- CcLinkParams.Builder builder, boolean linkingStatically, boolean linkShared) {
- builder.addTransitiveTargets(
- ruleContext.getPrerequisites("deps", Mode.TARGET),
- CcLinkParamsStore.TO_LINK_PARAMS);
- }
- };
-
NestedSet<PathFragment> imports = common.collectImports(ruleContext, semantics);
if (ruleContext.hasErrors()) {
return null;
@@ -93,13 +78,11 @@ public abstract class PyLibrary implements RuleConfiguredTargetFactory {
RuleConfiguredTargetBuilder builder = new RuleConfiguredTargetBuilder(ruleContext);
common.addCommonTransitiveInfoProviders(builder, semantics, filesToBuild);
- CcLinkingInfo.Builder ccLinkingInfoBuilder = CcLinkingInfo.Builder.create();
- ccLinkingInfoBuilder.setCcLinkParamsStore(new CcLinkParamsStore(ccLinkParamsStore));
-
return builder
.setFilesToBuild(filesToBuild)
+ .addNativeDeclaredProvider(
+ semantics.buildCcLinkingInfoProvider(ruleContext.getPrerequisites("deps", Mode.TARGET)))
.add(RunfilesProvider.class, RunfilesProvider.simple(runfilesBuilder.build()))
- .addNativeDeclaredProvider(ccLinkingInfoBuilder.build())
.add(PythonImportsProvider.class, new PythonImportsProvider(imports))
.build();
}