aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/python/PyCommon.java
diff options
context:
space:
mode:
authorGravatar Ulf Adams <ulfjack@google.com>2016-04-19 11:32:24 +0000
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2016-04-19 13:51:07 +0000
commit83fce40e69ef35c90e69a57387b1f95b387ad453 (patch)
tree6a0acfb404629d0d8423217b89ca7b38ea9da2bb /src/main/java/com/google/devtools/build/lib/rules/python/PyCommon.java
parent0dbe07f017d391aba0613b4e6ca1503b62382ccd (diff)
Review a number of action subclasses and update them according to the spec.
Second pass. Consists of adding @Immutable annotations, adding final modifiers, and changing the types of fields to immutable types. -- MOS_MIGRATED_REVID=120216592
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/python/PyCommon.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/python/PyCommon.java9
1 files changed, 3 insertions, 6 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/python/PyCommon.java b/src/main/java/com/google/devtools/build/lib/rules/python/PyCommon.java
index 2b01aec41a..c375701f14 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/python/PyCommon.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/python/PyCommon.java
@@ -40,6 +40,7 @@ import com.google.devtools.build.lib.cmdline.PackageIdentifier;
import com.google.devtools.build.lib.collect.nestedset.NestedSet;
import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder;
import com.google.devtools.build.lib.collect.nestedset.Order;
+import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable;
import com.google.devtools.build.lib.packages.BuildType;
import com.google.devtools.build.lib.packages.Rule;
import com.google.devtools.build.lib.rules.cpp.CppFileTypes;
@@ -560,7 +561,8 @@ public final class PyCommon {
}
// Used purely to set the legacy ActionType of the ExtraActionInfo.
- private static class PyPseudoAction extends PseudoAction<PythonInfo> {
+ @Immutable
+ private static final class PyPseudoAction extends PseudoAction<PythonInfo> {
private static final UUID ACTION_UUID = UUID.fromString("8d720129-bc1a-481f-8c4c-dbe11dcef319");
public PyPseudoAction(ActionOwner owner,
@@ -569,10 +571,5 @@ public final class PyCommon {
PythonInfo info) {
super(ACTION_UUID, owner, inputs, outputs, mnemonic, infoExtension, info);
}
-
- @Override
- public ExtraActionInfo.Builder getExtraActionInfo() {
- return super.getExtraActionInfo();
- }
}
}