diff options
| author |  carmi <carmi@google.com> | 2017-12-13 08:07:46 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2017-12-13 08:09:21 -0800 |
| commit | 918a61165d7d5fee55f692f15c115e71182bdbc3 (patch) | |
| tree | c416439b33169d3b6b8892865884c8dbb7f907aa /src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCompileActionBuilder.java | |
| parent | 12beae1f8beabd1d70d17d3a7d1fc4a3d3b9c93f (diff) | |
Explain why --include_imports should not be used when creating the descriptor set output.
RELNOTES: None
PiperOrigin-RevId: 178904210
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCompileActionBuilder.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCompileActionBuilder.java | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCompileActionBuilder.java b/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCompileActionBuilder.java index b91e57f14b..849265738e 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCompileActionBuilder.java +++ b/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCompileActionBuilder.java @@ -390,6 +390,10 @@ public class ProtoCompileActionBuilder { return new ToolchainInvocation( "dontcare", ProtoLangToolchainProvider.create( + // Note: adding --include_imports here was requested multiple times, but it'll cause the + // output size to become quadratic, so don't. + // A rule that concatenates the artifacts from ctx.deps.proto.transitive_descriptor_sets + // provides similar results. "--descriptor_set_out=$(OUT)", null /* pluginExecutable */, null /* runtime */, |