diff options
author | plf <plf@google.com> | 2018-05-15 06:04:34 -0700 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-05-15 06:06:16 -0700 |
commit | 6b3e482e010f5e256f43013f661ed9f67a723784 (patch) | |
tree | 8605c7d61416789c96743c7da318ca68a7fd86dc /src/main/java/com/google/devtools/build/lib/rules/objc | |
parent | c4f2d80270f1ce947fcf7fb0a4e5f0afb3a7062d (diff) |
C++: Deletes CcLinkParamsInfo
This class is not necessary anymore. We can use CcLinkParamsStoreImpl directly
which has been renamed to CcLinkParamsStore.
RELNOTES:none
PiperOrigin-RevId: 196656488
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/objc')
4 files changed, 17 insertions, 17 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommon.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommon.java index f5a441ebd4..b4d0bac360 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommon.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommon.java @@ -70,7 +70,7 @@ import com.google.devtools.build.lib.rules.apple.AppleToolchain; import com.google.devtools.build.lib.rules.cpp.CcCompilationContext; import com.google.devtools.build.lib.rules.cpp.CcCompilationInfo; import com.google.devtools.build.lib.rules.cpp.CcLinkParams; -import com.google.devtools.build.lib.rules.cpp.CcLinkParamsInfo; +import com.google.devtools.build.lib.rules.cpp.CcLinkParamsStore; import com.google.devtools.build.lib.rules.cpp.CcLinkingInfo; import com.google.devtools.build.lib.rules.cpp.CppFileTypes; import com.google.devtools.build.lib.rules.cpp.CppModuleMap; @@ -172,7 +172,7 @@ public final class ObjcCommon { private Optional<Artifact> linkedBinary = Optional.absent(); private Optional<Artifact> linkmapFile = Optional.absent(); private Iterable<CcCompilationContext> depCcHeaderProviders = ImmutableList.of(); - private Iterable<CcLinkParamsInfo> depCcLinkProviders = ImmutableList.of(); + private Iterable<CcLinkParamsStore> depCcLinkProviders = ImmutableList.of(); /** * Builder for {@link ObjcCommon} obtaining both attribute data and configuration data from @@ -261,15 +261,15 @@ public final class ObjcCommon { ImmutableList.Builder<ObjcProvider> propagatedObjcDeps = ImmutableList.<ObjcProvider>builder(); ImmutableList.Builder<CcCompilationInfo> cppDeps = ImmutableList.builder(); - ImmutableList.Builder<CcLinkParamsInfo> cppDepLinkParams = - ImmutableList.<CcLinkParamsInfo>builder(); + ImmutableList.Builder<CcLinkParamsStore> cppDepLinkParams = + ImmutableList.<CcLinkParamsStore>builder(); for (ConfiguredTargetAndData dep : deps) { ConfiguredTarget depCT = dep.getConfiguredTarget(); addAnyProviders(propagatedObjcDeps, depCT, ObjcProvider.SKYLARK_CONSTRUCTOR); addAnyProviders(cppDeps, depCT, CcCompilationInfo.PROVIDER); if (isCcLibrary(dep)) { - cppDepLinkParams.add(depCT.get(CcLinkingInfo.PROVIDER).getCcLinkParamsInfo()); + cppDepLinkParams.add(depCT.get(CcLinkingInfo.PROVIDER).getCcLinkParamsStore()); CcCompilationContext ccCompilationContext = depCT.get(CcCompilationInfo.PROVIDER).getCcCompilationContext(); addDefines(ccCompilationContext.getDefines()); @@ -463,7 +463,7 @@ public final class ObjcCommon { objcProvider.addAll(DEFINE, headerProvider.getDefines()); textualHeaders.addAll(headerProvider.getTextualHdrs()); } - for (CcLinkParamsInfo linkProvider : depCcLinkProviders) { + for (CcLinkParamsStore linkProvider : depCcLinkProviders) { CcLinkParams params = linkProvider.getCcLinkParams(true, false); ImmutableList<String> linkOpts = params.flattenedLinkopts(); ImmutableSet.Builder<SdkFramework> frameworkLinkOpts = new ImmutableSet.Builder<>(); diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibrary.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibrary.java index 979ae10212..cd1793139b 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibrary.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibrary.java @@ -26,7 +26,7 @@ import com.google.devtools.build.lib.collect.nestedset.NestedSet; import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder; import com.google.devtools.build.lib.rules.cpp.CcCompilationContext; import com.google.devtools.build.lib.rules.cpp.CcCompilationInfo; -import com.google.devtools.build.lib.rules.cpp.CcLinkParamsInfo; +import com.google.devtools.build.lib.rules.cpp.CcLinkParamsStore; import com.google.devtools.build.lib.rules.cpp.CcLinkingInfo; import com.google.devtools.build.lib.rules.objc.ObjcCommon.ResourceAttributes; import com.google.devtools.build.lib.syntax.Type; @@ -109,8 +109,8 @@ public class ObjcLibrary implements RuleConfiguredTargetFactory { ccCompilationInfoBuilder.setCcCompilationContext(ccCompilationContext); CcLinkingInfo.Builder ccLinkingInfoBuilder = CcLinkingInfo.Builder.create(); - ccLinkingInfoBuilder.setCcLinkParamsInfo( - new CcLinkParamsInfo(new ObjcLibraryCcLinkParamsStore(common))); + ccLinkingInfoBuilder.setCcLinkParamsStore( + new CcLinkParamsStore(new ObjcLibraryCcLinkParamsStore(common))); return ObjcRuleClasses.ruleConfiguredTarget(ruleContext, filesToBuild.build()) .addNativeDeclaredProvider(common.getObjcProvider()) diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibraryCcLinkParamsStore.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibraryCcLinkParamsStore.java index d0d46b08e9..a97ba8403d 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibraryCcLinkParamsStore.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcLibraryCcLinkParamsStore.java @@ -17,17 +17,17 @@ package com.google.devtools.build.lib.rules.objc; import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableSet; import com.google.devtools.build.lib.actions.Artifact; +import com.google.devtools.build.lib.rules.cpp.AbstractCcLinkParamsStore; import com.google.devtools.build.lib.rules.cpp.ArtifactCategory; import com.google.devtools.build.lib.rules.cpp.CcLinkParams; -import com.google.devtools.build.lib.rules.cpp.CcLinkParamsStore; import com.google.devtools.build.lib.rules.cpp.LinkerInputs; import com.google.devtools.build.lib.rules.cpp.LinkerInputs.LibraryToLink; import com.google.devtools.build.lib.vfs.FileSystemUtils; /** - * A {@link CcLinkParamsStore} to be propagated to dependent cc_{library, binary} targets. + * A {@link AbstractCcLinkParamsStore} to be propagated to dependent cc_{library, binary} targets. */ -class ObjcLibraryCcLinkParamsStore extends CcLinkParamsStore { +class ObjcLibraryCcLinkParamsStore extends AbstractCcLinkParamsStore { private final ObjcCommon common; diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcProvider.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcProvider.java index 5998b72f45..127e5030a9 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcProvider.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcProvider.java @@ -33,7 +33,7 @@ import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable; import com.google.devtools.build.lib.packages.NativeInfo; import com.google.devtools.build.lib.packages.NativeProvider; import com.google.devtools.build.lib.packages.NativeProvider.WithLegacySkylarkName; -import com.google.devtools.build.lib.rules.cpp.CcLinkParamsInfo; +import com.google.devtools.build.lib.rules.cpp.CcLinkParamsStore; import com.google.devtools.build.lib.rules.cpp.CcLinkingInfo; import com.google.devtools.build.lib.rules.cpp.CppModuleMap; import com.google.devtools.build.lib.rules.cpp.LinkerInputs; @@ -950,16 +950,16 @@ public final class ObjcProvider extends NativeInfo { // three possible locations (and may be duplicated!): // 1. ObjcProvider.LIBRARY // 2. ObjcProvider.CC_LIBRARY - // 3. CcLinkParamsInfo->LibraryToLink->getArtifact() + // 3. CcLinkParamsStore->LibraryToLink->getArtifact() // TODO(cpeyser): Clean up objc-cc interop. HashSet<PathFragment> avoidLibrariesSet = new HashSet<>(); for (CcLinkingInfo linkProvider : avoidCcProviders) { - CcLinkParamsInfo ccLinkParamsInfo = linkProvider.getCcLinkParamsInfo(); - if (ccLinkParamsInfo == null) { + CcLinkParamsStore ccLinkParamsStore = linkProvider.getCcLinkParamsStore(); + if (ccLinkParamsStore == null) { continue; } NestedSet<LibraryToLink> librariesToLink = - ccLinkParamsInfo.getCcLinkParams(true, false).getLibraries(); + ccLinkParamsStore.getCcLinkParams(true, false).getLibraries(); for (LibraryToLink libraryToLink : librariesToLink.toList()) { avoidLibrariesSet.add(libraryToLink.getArtifact().getRunfilesPath()); } |