Add @CompileTimeConstant annotations to CustomCommandLine.

This enforces certain memory-efficient patterns. For deliberate use of dynamic strings, explicitly named overloads are introduced, with javadoc that guides the programmer into making the right choice.

This CL is a memory no-op on benchmarks, but it tries to prevent backslide by making sure programmers make conscious choices when they construct their command lines.

RELNOTES: None
PiperOrigin-RevId: 165185997

1 files changed, 3 insertions, 3 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ProtobufSupport.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ProtobufSupport.java
index 93f0c9a1b9..d7322d0f8e 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/objc/ProtobufSupport.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ProtobufSupport.java
@@ -470,12 +470,12 @@ final class ProtobufSupport {
   private CustomCommandLine getGenerationCommandLine(Artifact protoInputsFile) {
     return new Builder()
         .add("--input-file-list")
-        .add(protoInputsFile.getExecPathString())
+        .add(protoInputsFile)
         .add("--output-dir")
-        .add(getWorkspaceRelativeOutputDir().getSafePathString())
+        .addDynamicString(getWorkspaceRelativeOutputDir().getSafePathString())
         .add("--force")
         .add("--proto-root-dir")
-        .add(getGenfilesPathString())
+        .addDynamicString(getGenfilesPathString())
         .add("--proto-root-dir")
         .add(".")
         .add(VectorArg.of(portableProtoFilters).beforeEach("--config"))