diff options
author | 2016-03-16 22:59:19 +0000 | |
---|---|---|
committer | 2016-03-17 10:08:15 +0000 | |
commit | e9b588ecc54afdeb5d700c3ef3e78cd917063878 (patch) | |
tree | 21010f953f1c91dcce20c16ea91af5b3163038d8 /src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java | |
parent | 8c1138c0458f780f349a6d1e21821ca932c238bc (diff) |
Remove deprecated objc_options.
RELNOTES[INC]: Any project that depended on the objc_options rule will be broken. Can be fixed by adding attrs (infoplists,copts) directly to rules depending on the options.
--
MOS_MIGRATED_REVID=117393853
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java | 33 |
1 files changed, 0 insertions, 33 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java index c5594e60d9..461c06d11f 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcRuleClasses.java @@ -219,37 +219,6 @@ public class ObjcRuleClasses { } /** - * Common attributes for {@code objc_*} rules that use plists or copts. - */ - public static class OptionsRule implements RuleDefinition { - @Override - public RuleClass build(Builder builder, RuleDefinitionEnvironment env) { - return builder - // TODO(bazel-team): Remove options and replace with: (a) a plists attribute (instead of - // the current infoplist, defined on all rules and propagated to the next bundling rule) - // and (b) a way to share copts e.g. by being able to include constants across package - // boundaries in bazel. - // - // For now the semantics of this attribute are: any copts in the options will be used if - // defined on a compiling/linking rule, otherwise ignored. Infoplists are merged in if - // defined on a bundling rule, otherwise ignored. - .add(attr("options", LABEL) - .undocumented("objc_options will be removed") - .allowedFileTypes() - .allowedRuleClasses("objc_options")) - .build(); - } - - @Override - public Metadata getMetadata() { - return RuleDefinition.Metadata.builder() - .name("$objc_options_rule") - .type(RuleClassType.ABSTRACT) - .build(); - } - } - - /** * Attributes for {@code objc_*} rules that can link in SDK frameworks. */ public static class SdkFrameworksDependerRule implements RuleDefinition { @@ -662,7 +631,6 @@ public class ObjcRuleClasses { .ancestors( BaseRuleClasses.RuleBase.class, CompileDependencyRule.class, - OptionsRule.class, CoptsRule.class, XcrunRule.class) .build(); @@ -801,7 +769,6 @@ public class ObjcRuleClasses { .type(RuleClassType.ABSTRACT) .ancestors( AppleToolchain.RequiresXcodeConfigRule.class, - OptionsRule.class, ResourcesRule.class, ResourceToolsRule.class, XcrunRule.class) |