Remove BuildConfiguration.cacheKey() and replace .shortCacheKey() with a .checksum() method that is computed from the checksum of the build options. Also remove Fragment.cacheKey() and Fragment.getName().

The reasoning is that within a single build, if two BuildConfigurations share the same BuildOptions, they must be the same because BuildConfiguration can only be a function of BuildOptions, specific targets (which stay the same during a build) and BlazeDirectories (which stay the same during the lifetime of a server). Between different builds if the configurations are recreated, they will always be considered different because Java reference equality (==) is used for comparing BuildConfigurations.

Also remove "Serializable" tags from configuration-related things.

--
MOS_MIGRATED_REVID=97107881

1 files changed, 0 insertions, 10 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcConfiguration.java
index 25c83acc8e..08ebca85ad 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcConfiguration.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcConfiguration.java
@@ -254,16 +254,6 @@ public class ObjcConfiguration extends BuildConfiguration.Fragment {
     return configurationDistinguisher;
   }
 
-  @Override
-  public String getName() {
-    return "Objective-C";
-  }
-
-  @Override
-  public String cacheKey() {
-    return iosSdkVersion;
-  }
-
   @Nullable
   @Override
   public String getOutputDirectoryName() {