aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBundle.java
diff options
context:
space:
mode:
authorGravatar Peter Schmitt <schmitt@google.com>2015-05-13 23:25:45 +0000
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2015-05-15 09:44:44 +0000
commitb140749f869c4c963f9daffdda4927e3ca688939 (patch)
tree3f3369f0be727b2d990568fb87024e8c38a9dbde /src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBundle.java
parent39f3b66bfca31ef1198d4f80fce5b554fc7c637e (diff)
Simplify ConfiguredTarget construction.
This is part of a series of changes to reduce/remove ObjcCommon. In this case removing a method that added needless complexity. -- MOS_MIGRATED_REVID=93573019
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBundle.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBundle.java13
1 files changed, 5 insertions, 8 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBundle.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBundle.java
index 7eb806c1a5..4a4d34d994 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBundle.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcBundle.java
@@ -16,12 +16,12 @@ package com.google.devtools.build.lib.rules.objc;
import static com.google.devtools.build.lib.collect.nestedset.Order.STABLE_ORDER;
-import com.google.common.base.Optional;
import com.google.common.collect.ImmutableList;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.analysis.ConfiguredTarget;
import com.google.devtools.build.lib.analysis.RuleConfiguredTarget.Mode;
import com.google.devtools.build.lib.analysis.RuleContext;
+import com.google.devtools.build.lib.collect.nestedset.NestedSet;
import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder;
import com.google.devtools.build.lib.rules.RuleConfiguredTargetFactory;
@@ -41,12 +41,9 @@ public class ObjcBundle implements RuleConfiguredTargetFactory {
ruleContext.attributeError("bundle_imports", error);
}
- return common.configuredTarget(
- /*filesToBuild=*/NestedSetBuilder.<Artifact>emptySet(STABLE_ORDER),
- Optional.<XcodeProvider>absent(),
- Optional.of(common.getObjcProvider()),
- Optional.<XcTestAppProvider>absent(),
- Optional.<J2ObjcSrcsProvider>absent(),
- Optional.<J2ObjcMappingFileProvider>absent());
+ NestedSet<Artifact> filesToBuild = NestedSetBuilder.emptySet(STABLE_ORDER);
+ return ObjcRuleClasses.ruleConfiguredTarget(ruleContext, filesToBuild)
+ .addProvider(ObjcProvider.class, common.getObjcProvider())
+ .build();
}
}