aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibrary.java
diff options
context:
space:
mode:
authorGravatar Cal Peyser <cpeyser@google.com>2016-05-11 09:31:47 +0000
committerGravatar Klaus Aehlig <aehlig@google.com>2016-05-11 10:24:48 +0000
commit66ce9030d2d2a100593b90b1d0e2188001db2d3e (patch)
tree365b36228b8d78b12b156609ef5c57d676b0361c /src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibrary.java
parentf6fa7d94e7f682edb610e8ad651b131882e81779 (diff)
Reconcile cc and objc default compiler flags in the crosstool.
-- MOS_MIGRATED_REVID=122035585
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibrary.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibrary.java9
1 files changed, 6 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibrary.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibrary.java
index aef4f2795f..e3ec44eaa5 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibrary.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ExperimentalObjcLibrary.java
@@ -38,6 +38,8 @@ import java.util.Collection;
public class ExperimentalObjcLibrary implements RuleConfiguredTargetFactory {
private static final String PCH_FILE_VARIABLE_NAME = "pch_file";
+ private static final Iterable<String> ACTIVATED_ACTIONS =
+ ImmutableList.of("objc-compile", "objc++-compile");
private VariablesExtension variablesExtension(final RuleContext ruleContext) {
return new VariablesExtension() {
@@ -66,13 +68,14 @@ public class ExperimentalObjcLibrary implements RuleConfiguredTargetFactory {
.getPrerequisite(":cc_toolchain", Mode.TARGET)
.getProvider(CcToolchainProvider.class);
- ImmutableList.Builder<String> extraFeatures = ImmutableList.builder();
+ ImmutableList.Builder<String> activatedCrosstoolSelectables =
+ ImmutableList.<String>builder().addAll(ACTIVATED_ACTIONS);
if (ruleContext.getPrerequisiteArtifact("pch", Mode.TARGET) != null) {
- extraFeatures.add("pch");
+ activatedCrosstoolSelectables.add("pch");
}
FeatureConfiguration featureConfiguration =
- toolchain.getFeatures().getFeatureConfiguration(extraFeatures.build());
+ toolchain.getFeatures().getFeatureConfiguration(activatedCrosstoolSelectables.build());
Collection<Artifact> sources = Sets.newHashSet(compilationArtifacts.getSrcs());