diff options
author | 2016-08-16 15:56:19 +0000 | |
---|---|---|
committer | 2016-08-17 11:23:53 +0000 | |
commit | fa6f40300d7f998ab20b7e8ecc190059c0fcb042 (patch) | |
tree | 5d2d4210de4ba60f1a7d0d614fa1e7c25c517cce /src/main/java/com/google/devtools/build/lib/rules/objc/BinaryLinkingTargetFactory.java | |
parent | 29a4982e83c469bce380874d431e32b841f1a0c4 (diff) |
Make the proto bundling behavior the default when using the new library. Take 2
--
MOS_MIGRATED_REVID=130406840
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/objc/BinaryLinkingTargetFactory.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/objc/BinaryLinkingTargetFactory.java | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/BinaryLinkingTargetFactory.java b/src/main/java/com/google/devtools/build/lib/rules/objc/BinaryLinkingTargetFactory.java index c584268458..88ac93a54d 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/BinaryLinkingTargetFactory.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/BinaryLinkingTargetFactory.java @@ -72,17 +72,11 @@ abstract class BinaryLinkingTargetFactory implements RuleConfiguredTargetFactory @Override public final ConfiguredTarget create(RuleContext ruleContext) throws InterruptedException, RuleErrorException { - ObjcConfiguration objcConfiguration = ObjcRuleClasses.objcConfiguration(ruleContext); - - Optional<ObjcProvider> protosObjcProvider = Optional.absent(); - Optional<XcodeProvider> protosXcodeProvider = Optional.absent(); - if (objcConfiguration.experimentalAutoTopLevelUnionObjCProtos()) { - ProtobufSupport protoSupport = - new ProtobufSupport(ruleContext).registerGenerationActions().registerCompilationActions(); + ProtobufSupport protoSupport = + new ProtobufSupport(ruleContext).registerGenerationActions().registerCompilationActions(); - protosObjcProvider = Optional.of(protoSupport.getObjcProvider()); - protosXcodeProvider = Optional.of(protoSupport.getXcodeProvider()); - } + Optional<ObjcProvider> protosObjcProvider = protoSupport.getObjcProvider(); + Optional<XcodeProvider> protosXcodeProvider = protoSupport.getXcodeProvider(); ObjcCommon common = common(ruleContext, protosObjcProvider); @@ -128,6 +122,7 @@ abstract class BinaryLinkingTargetFactory implements RuleConfiguredTargetFactory Optional<XcTestAppProvider> xcTestAppProvider; Optional<RunfilesSupport> maybeRunfilesSupport = Optional.absent(); + ObjcConfiguration objcConfiguration = ObjcRuleClasses.objcConfiguration(ruleContext); switch (hasReleaseBundlingSupport) { case YES: AppleConfiguration appleConfiguration = ruleContext.getFragment(AppleConfiguration.class); |