diff options
| author |  ulfjack <ulfjack@google.com> | 2018-01-10 02:50:07 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-01-10 02:59:23 -0800 |
| commit | 1c59e78215f7beaa10229df48f483779ebad8217 (patch) | |
| tree | 4a4d2b3cd22f04992a0b9c57bb25a6b53b5606d2 /src/main/java/com/google/devtools/build/lib/rules/java/proto/JavaLiteProtoAspect.java | |
| parent | 512b9b9b353bcabc436a87329fadd449c684c44b (diff) | |
Adjust semantics of Metadata interface, remove isFile (use getType)
After some consideration, I think it makes sense to always allow a getDigest call, instead of specifying it as disallowed based on type. This is a follow-up CL for a previous CL introducing the getType method, which increased the complexity of the specification.
I have a follow-up CL, which is related, namely unknown commit. After that CL, Metadata instances for directories (but not Filesets) also have digests rather than using mtime, which is compatible with the documentation changes made here. Said CL is solving a correctness issue with directory dependencies, which I think we want, and using the digest in the Metadata is a natural way to get correct action cache lookups.
PiperOrigin-RevId: 181440548
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/java/proto/JavaLiteProtoAspect.java')
0 files changed, 0 insertions, 0 deletions