aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
diff options
context:
space:
mode:
authorGravatar lberki <lberki@google.com>2017-12-06 01:49:14 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2017-12-06 01:50:47 -0800
commit6183faff6c627d5c0b36f36624f78de2f9dcbab0 (patch)
treefc3fbc77a1d164541ddc4864db34082b25566077 /src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
parentbec2fe85bdf07d944d0cb650b59732ea8d3e804c (diff)
Disallow undeclared access to the $(JAVA) and $(JAVABASE) template variables.
If a rule needs these template variables, it will need to declare a dependency on them in the future by adding @bazel_tools//tools/jdk:current_java_runtime to its toolchains= attribute. RELNOTES[INC]: In order to access the template variables $(JAVA) and $(JAVABASE), @bazel_tools//tools/jdk:current_java_runtime needs to be added to the toolchains= attribute from now on. RELNOTES: None. PiperOrigin-RevId: 178070807
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java13
1 files changed, 0 insertions, 13 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
index db48af74a1..fc5bca7fad 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
@@ -531,18 +531,6 @@ public class JavaOptions extends FragmentOptions {
)
public boolean jplPropagateCcLinkParamsStore;
- @Option(
- name = "experimental_enable_jvm_configuration_make_variables",
- defaultValue = "true",
- documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
- effectTags = {OptionEffectTag.UNKNOWN},
- metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
- help = "If enabled, the Java configuration fragment supplies the JAVA and JAVABASE "
- + "Make variables. This option is used in the migration to remove them in favor of "
- + "requiring an explicit dependency on the Java runtime for rules that use them."
- )
- public boolean enableMakeVariables;
-
// Plugins are built using the host config. To avoid cycles we just don't propagate
// this option to the host config. If one day we decide to use plugins when building
// host tools, we can improve this by (for example) creating a compiler configuration that is
@@ -588,7 +576,6 @@ public class JavaOptions extends FragmentOptions {
host.allowRuntimeDepsOnNeverLink = allowRuntimeDepsOnNeverLink;
host.jplPropagateCcLinkParamsStore = jplPropagateCcLinkParamsStore;
- host.enableMakeVariables = enableMakeVariables;
return host;
}