aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/filegroup
diff options
context:
space:
mode:
authorGravatar Liam Miller-Cushon <cushon@google.com>2017-01-13 02:39:03 +0000
committerGravatar Marcel Hlopko <hlopko@google.com>2017-01-13 10:58:46 +0000
commit2bb34e17943709f26bec9fe534a181011e4700e3 (patch)
tree7f1a03e2dd992afeebab6a42227355153f0ed04f /src/main/java/com/google/devtools/build/lib/rules/filegroup
parent81792d410c48b69c7c99f0fa1deb748ac84dc7f0 (diff)
Avoid materializing the nested set for filegroup srcs
and then wrapping it in another nested set. -- PiperOrigin-RevId: 144398091 MOS_MIGRATED_REVID=144398091
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/filegroup')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/filegroup/Filegroup.java7
1 files changed, 2 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/filegroup/Filegroup.java b/src/main/java/com/google/devtools/build/lib/rules/filegroup/Filegroup.java
index c2ad7d91d8..e359e18187 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/filegroup/Filegroup.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/filegroup/Filegroup.java
@@ -22,6 +22,7 @@ import com.google.devtools.build.lib.analysis.CompilationHelper;
import com.google.devtools.build.lib.analysis.ConfiguredTarget;
import com.google.devtools.build.lib.analysis.MiddlemanProvider;
import com.google.devtools.build.lib.analysis.OutputGroupProvider;
+import com.google.devtools.build.lib.analysis.PrerequisiteArtifacts;
import com.google.devtools.build.lib.analysis.RuleConfiguredTarget.Mode;
import com.google.devtools.build.lib.analysis.RuleConfiguredTargetBuilder;
import com.google.devtools.build.lib.analysis.RuleContext;
@@ -30,7 +31,6 @@ import com.google.devtools.build.lib.analysis.RunfilesProvider;
import com.google.devtools.build.lib.analysis.TransitiveInfoCollection;
import com.google.devtools.build.lib.collect.nestedset.NestedSet;
import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder;
-import com.google.devtools.build.lib.collect.nestedset.Order;
import com.google.devtools.build.lib.rules.RuleConfiguredTargetFactory;
import com.google.devtools.build.lib.rules.test.InstrumentedFilesCollector;
import com.google.devtools.build.lib.rules.test.InstrumentedFilesCollector.InstrumentationSpec;
@@ -38,7 +38,6 @@ import com.google.devtools.build.lib.rules.test.InstrumentedFilesProvider;
import com.google.devtools.build.lib.syntax.Type;
import com.google.devtools.build.lib.util.FileTypeSet;
import com.google.devtools.build.lib.vfs.PathFragment;
-
import java.util.Iterator;
import java.util.List;
@@ -62,9 +61,7 @@ public class Filegroup implements RuleConfiguredTargetFactory {
NestedSet<Artifact> filesToBuild =
outputGroupName.isEmpty()
- ? NestedSetBuilder.wrap(
- Order.STABLE_ORDER,
- ruleContext.getPrerequisiteArtifacts("srcs", Mode.TARGET).list())
+ ? PrerequisiteArtifacts.nestedSet(ruleContext, "srcs", Mode.TARGET)
: getArtifactsForOutputGroup(
outputGroupName, ruleContext.getPrerequisites("srcs", Mode.TARGET));