diff options
author | Ulf Adams <ulfjack@google.com> | 2016-04-19 12:55:12 +0000 |
---|---|---|
committer | Damien Martin-Guillerez <dmarting@google.com> | 2016-04-19 13:52:07 +0000 |
commit | 10993fe27a62d5a4e683a206291c1bd44a492daf (patch) | |
tree | 7d0926a88d1f40524a6d597f0685c7b9cca3dbc2 /src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionInfoFileWriteAction.java | |
parent | c31f4c544cf26424375dbd579338ef9680b97012 (diff) |
Review a number of action subclasses and update them according to the spec.
Consists of adding @Immutable annotations, adding final modifiers, and changing
the types of fields to immutable types.
--
MOS_MIGRATED_REVID=120221067
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionInfoFileWriteAction.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionInfoFileWriteAction.java | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionInfoFileWriteAction.java b/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionInfoFileWriteAction.java index bc3f79d61c..817234c1a4 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionInfoFileWriteAction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionInfoFileWriteAction.java @@ -21,6 +21,7 @@ import com.google.devtools.build.lib.actions.Artifact; import com.google.devtools.build.lib.actions.ExecException; import com.google.devtools.build.lib.actions.extra.ExtraActionInfo; import com.google.devtools.build.lib.analysis.actions.AbstractFileWriteAction; +import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable; import com.google.devtools.build.lib.util.Fingerprint; import com.google.devtools.build.lib.util.Preconditions; @@ -32,11 +33,12 @@ import java.io.OutputStream; * .xa file for use by an extra action. This can only be done at execution time because actions may * store information only known at execution time into the protocol buffer. */ -public class ExtraActionInfoFileWriteAction extends AbstractFileWriteAction { - private final Action shadowedAction; - +@Immutable // if shadowedAction is immutable +public final class ExtraActionInfoFileWriteAction extends AbstractFileWriteAction { private static final String UUID = "1759f81d-e72e-477d-b182-c4532bdbaeeb"; + private final Action shadowedAction; + ExtraActionInfoFileWriteAction(ActionOwner owner, Artifact extraActionInfoFile, Action shadowedAction) { super(owner, ImmutableList.<Artifact>of(), extraActionInfoFile, false); |