diff options
| author |  ruperts <ruperts@google.com> | 2017-11-21 16:37:13 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2017-11-21 16:38:50 -0800 |
| commit | 7967f3387e63723bb36b974f83a816265d404c38 (patch) | |
| tree | 1533cc8bd2d63e1db9426d8795df902d104a3d1a /src/main/java/com/google/devtools/build/lib/rules/cpp/SpawnGccStrategy.java | |
| parent | a2a3d8ca6634abb8f8dc184edb4ea01543de8505 (diff) | |
Return SpawnResults using a List instead of a Set.
Currently we don't care about the list order of SpawnResults. However, we may care about the list order later. Also, if the equals() method for SpawnResults is ever changed then it may be problematic to return SpawnResults in a Set.
Aside: ActionResults use SpawnResults to calculate cumulative execution times for Actions, and may provide other metrics in future.
RELNOTES: None.
PiperOrigin-RevId: 176579460
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/SpawnGccStrategy.java')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/cpp/SpawnGccStrategy.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/SpawnGccStrategy.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/SpawnGccStrategy.java index a5a82f1b13..4b64e2b7ad 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/SpawnGccStrategy.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/SpawnGccStrategy.java @@ -27,7 +27,7 @@ import com.google.devtools.build.lib.actions.Spawn; import com.google.devtools.build.lib.actions.SpawnActionContext; import com.google.devtools.build.lib.actions.SpawnResult; import com.google.devtools.build.lib.actions.UserExecException; -import java.util.Set; +import java.util.List; /** * A context for C++ compilation that calls into a {@link SpawnActionContext}. @@ -67,7 +67,7 @@ public class SpawnGccStrategy implements CppCompileActionContext { action.getOutputs().asList(), action.estimateResourceConsumptionLocal()); - Set<SpawnResult> spawnResults = + List<SpawnResult> spawnResults = actionExecutionContext .getSpawnActionContext(action.getMnemonic()) .exec(spawn, actionExecutionContext); |