diff options
author | 2017-08-29 17:57:35 +0200 | |
---|---|---|
committer | 2017-08-29 18:52:58 +0200 | |
commit | 7876d97dbe7d4593855e62667fa7eba5774b561b (patch) | |
tree | 41417385db45c966e8ffc2bdada03b4ae86604d7 /src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java | |
parent | 9981ca321a56d0e5fb023ce0922fdb60a93e380d (diff) |
Ensure ThinLTO backend actions always generate debug info when fission enabled
While we don't generate .dwp files for shared libraries, the link still expects the object files to contain split debug info.
Enhanced tests to ensure the cc_library LTO backend actions always have the expected outputs/build variable, regardless of linking static or not.
RELNOTES: NONE
PiperOrigin-RevId: 166853630
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java index c06f32b741..c6fbe44f10 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java @@ -199,7 +199,6 @@ public class CppLinkActionBuilder { private boolean isLtoIndexing = false; private boolean usePicForLtoBackendActions = false; - private boolean useFissionForLtoBackendActions = false; private Iterable<LtoBackendArtifacts> allLtoArtifacts = null; private final List<VariablesExtension> variablesExtensions = new ArrayList<>(); @@ -847,7 +846,7 @@ public class CppLinkActionBuilder { toolchain, fdoSupport, usePicForLtoBackendActions, - useFissionForLtoBackendActions); + cppConfiguration.useFission()); } } @@ -1011,12 +1010,6 @@ public class CppLinkActionBuilder { return this; } - /** Sets flag for using Fission in any scheduled LTO Backend actions. */ - public CppLinkActionBuilder setUseFissionForLtoBackendActions(boolean useFission) { - this.useFissionForLtoBackendActions = useFission; - return this; - } - /** Sets the C++ runtime library inputs for the action. */ public CppLinkActionBuilder setRuntimeInputs( ArtifactCategory runtimeType, Artifact middleman, NestedSet<Artifact> inputs) { |