diff options
| author |  Googler <noreply@google.com> | 2017-11-06 22:53:37 +0100 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2017-11-07 19:06:57 +0100 |
| commit | 49212e985d41b03d5e8cd4417f773748596587fe (patch) | |
| tree | 595ed4a3809289852991c64b340bf0dea7dba995 /src/main/java/com/google/devtools/build/lib/rules/cpp/CppHelper.java | |
| parent | d5f0ecb407f5708841e98e55d01d651a316ae7c2 (diff) | |
Add more assertions about test suite expansion behavior
Characterizing this correctly this time: Target patterns are evaluated with two different sets of semantics. For determining which targets to build, only test suites in exclusion target patterns are expanded. For determining which tests to run (or determining which targets to build if --build_tests_only is set), test suites in all target patterns are expanded. In each case, test suites are expanded for each target pattern individually, not for the whole set of targets after the list of target patterns is processed.
Also update a related code comment.
The newer implementation for this logic already has equivalent tests for this behavior, in particular testFilterNegativeTestFromTestSuite and testNegativeTestSuiteExpanded in LoadingPhaseRunnerTest.
RELNOTES: None
PiperOrigin-RevId: 174756583
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/CppHelper.java')
0 files changed, 0 insertions, 0 deletions