aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java
diff options
context:
space:
mode:
authorGravatar Lukacs Berki <lberki@google.com>2016-02-26 13:13:39 +0000
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2016-02-28 17:04:23 +0000
commitde62b4e9cd0f56473278811774ec191a4e0fafcd (patch)
treed5f18446ad3935c35340f84f0fcab7d3dceb47c3 /src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java
parentb8101f57681f292a9ec312a9cbbc84ac4ec0668d (diff)
Pass the source path -> Artifact mapping into FdoSupport from a provider instead of special-casing it.
This removes the need to deserialize artifacts in FdoSupport, which in turn removes the need to support artifact deserialization at all, which makes our lives simpler and Thoreauvian programming is good. -- MOS_MIGRATED_REVID=115660698
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java
index 5a5e17e05c..e46d1f76d6 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java
@@ -139,7 +139,7 @@ public class CppConfiguration extends BuildConfiguration.Fragment {
/**
* This enumeration is used for the --strip option.
*/
- public static enum StripMode {
+ public enum StripMode {
ALWAYS("always"), // Always strip.
SOMETIMES("sometimes"), // Strip iff compilationMode == FASTBUILD.
@@ -1923,10 +1923,10 @@ public class CppConfiguration extends BuildConfiguration.Fragment {
}
}
try {
- getFdoSupport().prepareToBuild(execRoot, artifactFactory, resolver);
+ getFdoSupport().prepareToBuild(execRoot);
} catch (ZipException e) {
throw new ViewCreationFailedException("Error reading provided FDO zip file", e);
- } catch (FdoException | IOException | PackageRootResolutionException e) {
+ } catch (FdoException | IOException e) {
throw new ViewCreationFailedException("Error while initializing FDO support", e);
}
}