Refactor all ctor callsites of PathFragment to instead call a static 'create' method.

This paves the way for changing PathFragment to e.g. an abstract class with multiple subclasses. This way we can split out the windows-specific stuff into one of these concrete classes, making the code more readable and also saving memory (since the shallow heap size of the NonWindowsPathFragment subclass will hopefully be smaller than that of the current PathFragment).

This also lets us pursue gc churn optimizations. We can now do interning in PathFragment#create and can also get rid of unnecessary intermediate PathFragment allocations.

RELNOTES: None

PiperOrigin-RevId: 152145768

1 files changed, 5 insertions, 5 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java
index f658f6732e..843a72c932 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java
@@ -190,7 +190,7 @@ public class CppConfiguration extends BuildConfiguration.Fragment {
       PathFragment defaultSysroot =
           toolchain.getBuiltinSysroot().length() == 0
               ? null
-              : new PathFragment(toolchain.getBuiltinSysroot());
+              : PathFragment.create(toolchain.getBuiltinSysroot());
       if ((defaultSysroot != null) && !defaultSysroot.isNormalized()) {
         throw new InvalidConfigurationException(
             "The built-in sysroot '" + defaultSysroot + "' is not normalized.");
@@ -502,7 +502,7 @@ public class CppConfiguration extends BuildConfiguration.Fragment {
 
     this.toolPaths = Maps.newHashMap();
     for (CrosstoolConfig.ToolPath tool : toolchain.getToolPathList()) {
-      PathFragment path = new PathFragment(tool.getPath());
+      PathFragment path = PathFragment.create(tool.getPath());
       if (!path.isNormalized()) {
         throw new IllegalArgumentException("The include path '" + tool.getPath()
             + "' is not normalized.");
@@ -604,7 +604,7 @@ public class CppConfiguration extends BuildConfiguration.Fragment {
     // The default value for optional string attributes is the empty string.
     PathFragment defaultSysroot = toolchain.getBuiltinSysroot().length() == 0
         ? null
-        : new PathFragment(toolchain.getBuiltinSysroot());
+        : PathFragment.create(toolchain.getBuiltinSysroot());
     if ((defaultSysroot != null) && !defaultSysroot.isNormalized()) {
       throw new IllegalArgumentException("The built-in sysroot '" + defaultSysroot
           + "' is not normalized.");
@@ -791,7 +791,7 @@ public class CppConfiguration extends BuildConfiguration.Fragment {
               gccToolPath = tool.getPath();
               linkerToolPath =
                   crosstoolTopPathFragment
-                      .getRelative(new PathFragment(tool.getPath()))
+                      .getRelative(PathFragment.create(tool.getPath()))
                       .getPathString();
             }
           }
@@ -1181,7 +1181,7 @@ public class CppConfiguration extends BuildConfiguration.Fragment {
       }
     }
 
-    PathFragment path = new PathFragment(pathString);
+    PathFragment path = PathFragment.create(pathString);
     if (!path.isNormalized()) {
       throw new InvalidConfigurationException("The include path '" + s + "' is not normalized.");
     }