aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java
diff options
context:
space:
mode:
authorGravatar Lukacs Berki <lberki@google.com>2016-05-18 13:47:41 +0000
committerGravatar Kristina Chodorow <kchodorow@google.com>2016-05-19 16:26:39 +0000
commit02b35351204097dd04a3cf045f8d7571d7775c11 (patch)
tree60ed64f48636115977da68f311f4178faf0367d6 /src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java
parent9f046cba37de6088b2f81717bc263889a5146d86 (diff)
Turn the addition of -fPIC to the command line of PIC actions into a feature.
This is a resubmission of commit 45d48bf1fe7503acbbb0c095822b7f8f558881e8. It turns out that we also need -fPIC for *assembler* command line options, because some assembler sources are preprocessed and they can say "#ifdef __PIC__". -- MOS_MIGRATED_REVID=122626234
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java4
1 files changed, 0 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java
index 721ad0f889..f3f024d5e3 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java
@@ -1415,10 +1415,6 @@ public class CppCompileAction extends AbstractAction
options.add("-E");
}
- if (usePic) {
- options.add("-fPIC");
- }
-
return options;
}